Akmal / fix: duration dropdown height when switching between different trade types #13343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akmal-deriv
requested review from
ali-hosseini-deriv,
matin-deriv and
maryia-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-akmal-deriv-b-duration-display.binary.sx/ |
henry-deriv
approved these changes
Feb 5, 2024
kate-deriv
reviewed
Feb 5, 2024
kate-deriv
approved these changes
Feb 5, 2024
maryia-deriv
changed the title
maryia-deriv
previously approved these changes
Feb 5, 2024
balakrishna-deriv
previously approved these changes
Feb 6, 2024
ahmadtaimoor-deriv
approved these changes
Feb 6, 2024
akmal-deriv
dismissed stale reviews from balakrishna-deriv and maryia-deriv
via
1fb0af2
kate-deriv
approved these changes
Feb 13, 2024
balakrishna-deriv
approved these changes
Feb 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This fix addresses an issue related to the height of the duration dropdown when switching between different trade options. Previously, the height of the dropdown might have remained static or incorrect when transitioning between various trade selections, leading to layout inconsistencies and usability challenges. With this update, the duration dropdown now dynamically adjusts its height according to the selected trade option, ensuring proper alignment and visibility of all dropdown items. Users can now switch between trade options seamlessly without encountering layout disruptions or obscured dropdown content. This enhancement improves the overall usability and consistency of the trading interface, providing a smoother and more intuitive user experience.