Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEQ] P2P-V2 My Profile balance test #13398

Merged

Conversation

adrienne-deriv
Copy link
Contributor

@adrienne-deriv adrienne-deriv commented Feb 7, 2024

Changes:

Please provide a summary of the change.

  • Added test cases for my profile balance

Screenshots:

Screenshot 2024-02-07 at 10 39 49 AM

Please provide some screenshots of the change.

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 7, 2024 4:15am

currency={currency}
isModalOpen={shouldShowDailyLimitModal}
onRequestClose={() => setShouldShowDailyLimitModal(false)}
/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this modal as it was already included in <MyProfileDailyLimit />

@adrienne-deriv adrienne-deriv marked this pull request as ready for review February 7, 2024 01:02
Copy link
Contributor

github-actions bot commented Feb 7, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13398](https://github.com/binary-com/deriv-app/pull/13398)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-p2p-v2-my-profile-bala-91e0af.binary.sx?qa_server=red.derivws.com&app_id=23879
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-p2p-v2-my-profile-bala-91e0af.binary.sx
- **App ID**: `23879`

Copy link
Contributor

github-actions bot commented Feb 7, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-p2p-v2-my-profile-bala-91e0af.binary.sx/

@coveralls
Copy link

coveralls commented Feb 7, 2024

Coverage Status

coverage: 35.472% (+0.1%) from 35.357%
when pulling 137c6a5 on adrienne-deriv:p2p-v2-my-profile-balance-test
into 56fc4df on binary-com:master.

Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
2.7% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Generating Lighthouse report...

@farrah-deriv farrah-deriv merged commit b37a9ff into binary-com:master Feb 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants