Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEQ] Farhan/FEQ-1584/Trader - CSS cleanup #13514

Conversation

farhan-nurzi-deriv
Copy link
Contributor

Changes:

Removing unused css files

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 20, 2024 7:47am

Copy link
Contributor

github-actions bot commented Feb 13, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13514](https://github.com/binary-com/deriv-app/pull/13514)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-feq-1584tra-68b62e.binary.sx?qa_server=red.derivws.com&app_id=24189
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-feq-1584tra-68b62e.binary.sx
- **App ID**: `24189`

Copy link
Contributor

github-actions bot commented Feb 13, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-feq-1584tra-68b62e.binary.sx/

@coveralls
Copy link

coveralls commented Feb 13, 2024

Coverage Status

coverage: 36.809%. remained the same
when pulling 0fce09b on farhan-nurzi-deriv:farhan/FEQ-1584/trader-css-cleanup
into e69f68b on binary-com:master.

Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
11.6% Duplication on New Code

See analysis details on SonarCloud

@maryia-deriv maryia-deriv merged commit a8be16a into binary-com:master Feb 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants