Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COJ] Shaheer / Hooks / Fixes useSettings hook #13529

Merged

Conversation

shaheer-deriv
Copy link
Contributor

Changes:

  • Enables the useSettings hook only on successful authorization

Screenshots:

Screenshot 2024-02-13 at 5 34 37 PM

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 13, 2024 2:03pm

Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13529](https://github.com/binary-com/deriv-app/pull/13529)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shaheer-deriv-shaheer-fix-usesettings-hook.binary.sx?qa_server=red.derivws.com&app_id=24041
    - **Original**: https://deriv-app-git-fork-shaheer-deriv-shaheer-fix-usesettings-hook.binary.sx
- **App ID**: `24041`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shaheer-deriv-shaheer-fix-usesettings-hook.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 36.117%. remained the same
when pulling b4f9917 on shaheer-deriv:shaheer/fix-usesettings-hook
into 9a02b06 on binary-com:master.

@amina-deriv amina-deriv merged commit d4ccad6 into binary-com:master Feb 20, 2024
6 checks passed
@shaheer-deriv shaheer-deriv deleted the shaheer/fix-usesettings-hook branch February 26, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants