Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sergei / WEBREL-2520 / When a MF account is created through script, user is not able to complete Trading Experience Assessment on staging #13635

Conversation

sergei-deriv
Copy link
Contributor

Changes:

  • make onSave function optional

Video:

Screen.Recording.2024-02-16.at.13.58.11.mov

Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 16, 2024 11:37am

@sergei-deriv sergei-deriv changed the title Sergei / no card / User is not able to complete Trading Experience Assessment Sergei / WEBREL-2520 / When a MF account is created through script, user is not able to complete Trading Experience Assessment on staging Feb 16, 2024
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13635](https://github.com/binary-com/deriv-app/pull/13635)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-new-bugtrading-as-4dec35.binary.sx?qa_server=red.derivws.com&app_id=24075
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-new-bugtrading-as-4dec35.binary.sx
- **App ID**: `24075`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-new-bugtrading-as-4dec35.binary.sx/

@vinu-deriv vinu-deriv merged commit 392a341 into binary-com:rc_V20240212_0 Feb 19, 2024
5 checks passed
vinu-deriv pushed a commit to vinu-deriv/deriv-app that referenced this pull request Feb 19, 2024
vinu-deriv added a commit that referenced this pull request Feb 19, 2024
Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants