Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEQ] P2P-V2 useAdvertiserStats hook test case #13647

Merged

Conversation

adrienne-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Added test case for useAdvertiserStats
Screenshot 2024-02-19 at 1 50 46 PM

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 19, 2024 10:51am

Copy link
Contributor

github-actions bot commented Feb 19, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13647](https://github.com/binary-com/deriv-app/pull/13647)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-p2p-v2-use-advertiser-9ca835.binary.sx?qa_server=red.derivws.com&app_id=32479
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-p2p-v2-use-advertiser-9ca835.binary.sx
- **App ID**: `32479`

Copy link
Contributor

github-actions bot commented Feb 19, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-p2p-v2-use-advertiser-9ca835.binary.sx/

@coveralls
Copy link

coveralls commented Feb 19, 2024

Coverage Status

coverage: 36.767% (+0.07%) from 36.697%
when pulling 4d5211d on adrienne-deriv:p2p-v2-use-advertiser-stats-test
into 213b5c4 on binary-com:master.

Copy link
Contributor

@ameerul-deriv ameerul-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
13.5% Duplication on New Code

See analysis details on SonarCloud

@farrah-deriv farrah-deriv merged commit 5947bf2 into binary-com:master Feb 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants