Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisyahlen/TRAH-2986/chore: replace clsx with tailwind-merge #13700

Merged

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Use tailwind-merge instead of clsx because it can merge same incoming styles
  2. Have access to twMerge and twJoin

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Feb 20, 2024
@thisyahlen-deriv thisyahlen-deriv self-assigned this Feb 20, 2024
Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 21, 2024 3:52am

@thisyahlen-deriv thisyahlen-deriv changed the title thisyahlen/chore: replace clsx with tailwind-merge thisyahlen/TRAH-2986/chore: replace clsx with tailwind-merge Feb 20, 2024
Copy link
Contributor

github-actions bot commented Feb 20, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13700](https://github.com/binary-com/deriv-app/pull/13700)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-tailwind-merge.binary.sx?qa_server=red.derivws.com&app_id=24036
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-tailwind-merge.binary.sx
- **App ID**: `24036`

Copy link
Contributor

github-actions bot commented Feb 20, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-tailwind-merge.binary.sx/

@coveralls
Copy link

coveralls commented Feb 20, 2024

Coverage Status

coverage: 36.835% (-0.008%) from 36.843%
when pulling 26c6aa1 on thisyahlen-deriv:thisyahlen/tailwind-merge
into 4f4fe75 on binary-com:master.

matin-deriv
matin-deriv previously approved these changes Feb 20, 2024
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Generating Lighthouse report...

@mahdiyeh-deriv mahdiyeh-deriv merged commit 396b2e8 into binary-com:master Feb 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants