Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thisyahlen/bump UI version #13740

Merged

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Bump up deriv-com/ui version

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Feb 22, 2024
@thisyahlen-deriv thisyahlen-deriv self-assigned this Feb 22, 2024
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 22, 2024 1:35am

Copy link
Contributor

github-actions bot commented Feb 22, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13740](https://github.com/binary-com/deriv-app/pull/13740)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-bumpuiversion.binary.sx?qa_server=red.derivws.com&app_id=24218
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-bumpuiversion.binary.sx
- **App ID**: `24218`

Copy link
Contributor

github-actions bot commented Feb 22, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-bumpuiversion.binary.sx/

Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Feb 22, 2024

Coverage Status

coverage: 37.043% (-0.009%) from 37.052%
when pulling 4b7009c on thisyahlen-deriv:thisyahlen/bump_ui_version
into 3e132ef on binary-com:master.

Copy link
Contributor

Generating Lighthouse report...

@mahdiyeh-deriv mahdiyeh-deriv merged commit ff39189 into binary-com:master Feb 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants