Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH-2979] shahzaib / restructure real account creation flow #13745

Conversation

shahzaib-deriv
Copy link
Contributor

@shahzaib-deriv shahzaib-deriv commented Feb 22, 2024

Changes:

Restructure real account creation flow in Tradershub V2

  • folder structure
  • renamed files related to real account creation
  • small styles tweaks
  • phone field validation (min, max)
  • removed unused installed packages

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 22, 2024 5:09am

Copy link
Contributor

github-actions bot commented Feb 22, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13745](https://github.com/binary-com/deriv-app/pull/13745)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-trah-2979-restructure-25a295.binary.sx?qa_server=red.derivws.com&app_id=24219
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-trah-2979-restructure-25a295.binary.sx
- **App ID**: `24219`

Copy link
Contributor

github-actions bot commented Feb 22, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-trah-2979-restructure-25a295.binary.sx/

@shahzaib-deriv shahzaib-deriv self-assigned this Feb 22, 2024
@shahzaib-deriv shahzaib-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Feb 22, 2024
@coveralls
Copy link

coveralls commented Feb 22, 2024

Coverage Status

coverage: 37.043% (-0.007%) from 37.05%
when pulling be182f7 on shahzaib-deriv:TRAH-2979-restructure-real-account-creation
into 55d5ee7 on binary-com:master.

…into TRAH-2979-restructure-real-account-creation
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Generating Lighthouse report...

@mahdiyeh-deriv mahdiyeh-deriv merged commit 23b57fd into binary-com:master Feb 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants