Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH-2991] shahzaib / real account currency selector config from website status #13763

Conversation

shahzaib-deriv
Copy link
Contributor

Changes:

Show currencies in currency selector based on website_status api call

@shahzaib-deriv shahzaib-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Feb 23, 2024
Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 23, 2024 4:04am

Copy link
Contributor

github-actions bot commented Feb 23, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13763](https://github.com/binary-com/deriv-app/pull/13763)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-real-account-currency-ddf44d.binary.sx?qa_server=red.derivws.com&app_id=24059
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-real-account-currency-ddf44d.binary.sx
- **App ID**: `24059`

Copy link
Contributor

github-actions bot commented Feb 23, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-real-account-currency-ddf44d.binary.sx/

@coveralls
Copy link

coveralls commented Feb 23, 2024

Coverage Status

coverage: 37.233% (-0.002%) from 37.235%
when pulling 76c1a9d on shahzaib-deriv:real-account-currency-selector-config
into 0505cce on binary-com:master.

Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@matin-deriv matin-deriv merged commit e839280 into binary-com:master Feb 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants