Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matin/Chore: Update CODEOWNERS for tradershub #13767

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

matin-deriv
Copy link
Contributor

Changes:

This PR is created to update the CODEOWNERS file with the focus on Trader's Hub package.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 23, 2024 7:27am

Copy link
Contributor

github-actions bot commented Feb 23, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13767](https://github.com/binary-com/deriv-app/pull/13767)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-matin-deriv-matin-updatecodeownersth.binary.sx?qa_server=red.derivws.com&app_id=31468
    - **Original**: https://deriv-app-git-fork-matin-deriv-matin-updatecodeownersth.binary.sx
- **App ID**: `31468`

Copy link
Contributor

github-actions bot commented Feb 23, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-matin-deriv-matin-updatecodeownersth.binary.sx/

.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
11.2% Duplication on New Code

See analysis details on SonarCloud

@matin-deriv matin-deriv merged commit f00de6b into binary-com:master Feb 23, 2024
5 of 6 checks passed
@coveralls
Copy link

Coverage Status

coverage: 37.232%. remained the same
when pulling 912d70e on matin-deriv:matin/update_codeowners_th
into e839280 on binary-com:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants