Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thisyahlen/replace quill in modules accounts v2 #13800

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Remove quill base styles and replace with tailwind base styles
  2. Used twMerge from tailwind-merge to replace qtMerge

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 27, 2024 7:23am

Copy link
Contributor

github-actions bot commented Feb 27, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13800](https://github.com/binary-com/deriv-app/pull/13800)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-replacequ-f1914e.binary.sx?qa_server=red.derivws.com&app_id=32113
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-replacequ-f1914e.binary.sx
- **App ID**: `32113`

Copy link
Contributor

github-actions bot commented Feb 27, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-replacequ-f1914e.binary.sx/

@coveralls
Copy link

coveralls commented Feb 27, 2024

Coverage Status

coverage: 37.667% (+0.08%) from 37.583%
when pulling d16a25f on thisyahlen-deriv:thisyahlen/replace_quill_in_modules_accounts-v2
into 2e1a36c on binary-com:master.

packages/account-v2/tsconfig.json Outdated Show resolved Hide resolved
packages/account-v2/tailwind.config.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

@matin-deriv matin-deriv merged commit 6433938 into binary-com:master Feb 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants