Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-3517 / Withdrawal locked currency config load #13918

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Updated useCurrencyConfig isLoading
  • Updated withdrawal locked to wait for currency config loading
  • Separated checks for withdrawal limit reached and withdrawal locked
  • Updated unit tests for withdrawal locked and withdrawal locked content

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 29, 2024 0:05am

Copy link
Contributor

github-actions bot commented Feb 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13918](https://github.com/binary-com/deriv-app/pull/13918)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-3517-withdrawal-lim-ff4e95.binary.sx?qa_server=red.derivws.com&app_id=38863
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-3517-withdrawal-lim-ff4e95.binary.sx
- **App ID**: `38863`

Copy link
Contributor

github-actions bot commented Feb 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-3517-withdrawal-lim-ff4e95.binary.sx/

@coveralls
Copy link

coveralls commented Feb 29, 2024

Coverage Status

coverage: 37.134% (+0.008%) from 37.126%
when pulling 8645105 on lubega-deriv:WALL-3517/withdrawal-limit-reached-currency-config-issue
into 346b32c on binary-com:master.

Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
19.5% Duplication on New Code

See analysis details on SonarCloud

@nijil-deriv nijil-deriv merged commit fc2b538 into binary-com:master Feb 29, 2024
6 checks passed
Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants