Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRO/490: Real sign up Tracking: nulls, CR, MF, ML, nu? data quality #14301

Merged
merged 5 commits into from
Apr 10, 2024
Merged

CRO/490: Real sign up Tracking: nulls, CR, MF, ML, nu? data quality #14301

merged 5 commits into from
Apr 10, 2024

Conversation

NikitK-deriv
Copy link
Contributor

To fix wrong values for rudderstack account type field in looker studio

Please provide a summary of the change.

Looker studio:
Screenshot 2024-03-21 at 15 44 25
Not auth user:
Screenshot 2024-03-21 at 15 08 29
Demo account:
Screenshot 2024-03-21 at 15 14 00

Please provide some screenshots of the change.

@boring-cyborg boring-cyborg bot added the Core label Mar 21, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 10, 2024 8:16am

@NikitK-deriv NikitK-deriv changed the title Real sign up Tracking: nulls, CR, MF, ML, nu? data quality CRO/490: Real sign up Tracking: nulls, CR, MF, ML, nu? data quality Mar 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 21, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/14301](https://github.com/binary-com/deriv-app/pull/14301)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nikitk-deriv-cro-490-real-signup-trac-5b3713.binary.sx?qa_server=red.derivws.com&app_id=23824
    - **Original**: https://deriv-app-git-fork-nikitk-deriv-cro-490-real-signup-trac-5b3713.binary.sx
- **App ID**: `23824`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 21, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-nikitk-deriv-cro-490-real-signup-trac-5b3713.binary.sx/

@coveralls
Copy link

coveralls commented Mar 21, 2024 •
edited
Loading

Coverage Status

coverage: 40.037% (+0.5%) from 39.529%
when pulling 3e6cbd5 on NikitK-deriv:cro-490-real-signup-tracking-issue-account-types
into dfe3893 on binary-com:master.

amir-deriv
amir-deriv reviewed Mar 26, 2024
View reviewed changes
packages/core/src/App/AppContent.tsx Outdated Show resolved Hide resolved
packages/core/src/Stores/client-store.js Outdated Show resolved Hide resolved
maryia-deriv
maryia-deriv previously approved these changes Apr 1, 2024
View reviewed changes
amir-deriv
amir-deriv approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@amir-deriv amir-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
120 New issues
5 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
10.4% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

@heorhi-deriv heorhi-deriv merged commit b51d145 into binary-com:master Apr 10, 2024
7 checks passed
@shahzaib-deriv shahzaib-deriv mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ali-hosseini-deriv ali-hosseini-deriv ali-hosseini-deriv left review comments

@heorhi-deriv heorhi-deriv heorhi-deriv approved these changes

@amir-deriv amir-deriv amir-deriv approved these changes

@maryia-deriv maryia-deriv maryia-deriv left review comments

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

Assignees
No one assigned
Labels
Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NikitK-deriv @coveralls @ali-hosseini-deriv @maryia-deriv @heorhi-deriv @amir-deriv