Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH]/Mitra/TRAH-3251/Update description and texts in traders hub #14854

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe('AddOptionsAccount', () => {
wrapper,
});
expect(container).toBeInTheDocument();
expect(screen.getByText('You need a Deriv account to create a CFD account.')).toBeInTheDocument();
expect(screen.getByText('To trade CFDs, get a Deriv Apps account first.')).toBeInTheDocument();
expect(screen.getByText('Get a Deriv account')).toBeInTheDocument();
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const AddOptions = observer(() => {
const { setShouldShowCooldownModal, openRealAccountSignup } = ui;
const { real_account_creation_unlock_date } = client;

const add_deriv_account_text = localize('You need a Deriv account to create a CFD account.');
const add_deriv_account_text = localize('To trade CFDs, get a Deriv Apps account first.');
const add_deriv_account_btn = localize('Get a Deriv account');

const eu_user = content_flag === ContentFlag.LOW_RISK_CR_EU || content_flag === ContentFlag.EU_REAL;
Expand Down
4 changes: 1 addition & 3 deletions packages/appstore/src/components/cfds-listing/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,7 @@ const CFDsListing = observer(() => {
description={
<Text size='xs' line_height='s'>
<Localize
i18n_default_text={
'Trade with leverage and tight spreads for better returns on successful trades. <0>Learn more</0>'
}
i18n_default_text={'Trade CFDs with high leverage and tight spreads. <0>Learn more</0>'}
components={[<StaticUrl key={0} className='options' href='/trade-types/cfds' />]}
/>
</Text>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const OptionsAndMultipliersListing = observer(() => {
if (low_risk_cr_non_eu || high_risk_cr || cr_demo) {
return (
<Text size='sm' weight='bold'>
<Localize i18n_default_text='Options & Multipliers' />
<Localize i18n_default_text='Options' />
</Text>
);
} else if (low_risk_cr_eu || is_eu) {
Expand All @@ -51,24 +51,19 @@ const OptionsAndMultipliersListing = observer(() => {
low_risk_cr_non_eu || high_risk_cr || cr_demo ? (
<Text size='xs' line_height='s'>
<Localize
i18n_default_text='Earn a range of payouts by correctly predicting market movements with <0>options</0>, or get the
upside of CFDs without risking more than your initial stake with <1>multipliers</1>.'
i18n_default_text='Buy or sell at a specific time for a specific price. <0>Learn more</0>'
components={[
<StaticUrl
key={0}
className='options'
href='trade-types/options/digital-options/up-and-down/'
/>,
<StaticUrl key={1} className='options' href='trade-types/multiplier/' />,
]}
/>
</Text>
) : (
<Text size='xs' line_height='s'>
<Localize
i18n_default_text='Get the upside of CFDs without risking more than your initial stake with <0>Multipliers</0>.'
components={[<StaticUrl key={0} className='options' href='trade-types/multiplier/' />]}
/>
<Localize i18n_default_text='Trade bigger positions with less capital across diverse financial and derived instruments.' />
</Text>
)
}
Expand All @@ -81,7 +76,11 @@ const OptionsAndMultipliersListing = observer(() => {
availability='All'
clickable_icon
name={localize('Deriv account')}
description={localize('Get a real Deriv account, start trading and manage your funds.')}
description={
is_eu_user
? localize('To trade multipliers, get a Deriv Apps account first.')
: localize('To trade options and multipliers, get a Deriv Apps account first.')
}
icon='Options'
onAction={() => {
if (no_MF_account) {
Expand Down
12 changes: 6 additions & 6 deletions packages/appstore/src/constants/platform-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,30 +34,30 @@ export interface MfPlatformConfig extends PlatformConfig {
export const getAppstorePlatforms = (): PlatformConfig[] => [
{
name: getPlatformSettingsAppstore('trader').name,
app_desc: localize('Options and multipliers trading platform.'),
app_desc: localize('The options and multipliers trading platform.'),
link_to: routes.trade,
},
{
name: getPlatformSettingsAppstore('dbot').name,
app_desc: localize('Automate your trading, no coding needed.'),
app_desc: localize('The ultimate bot trading platform.'),
link_to: routes.bot,
is_external: true,
},
{
name: getPlatformSettingsAppstore('smarttrader').name,
app_desc: localize('Our legacy options trading platform.'),
app_desc: localize('The legacy options trading platform.'),
link_to: getUrlSmartTrader(),
is_external: true,
},
{
name: getPlatformSettingsAppstore('bbot').name,
app_desc: localize('Our legacy automated trading platform.'),
app_desc: localize('The legacy bot trading platform.'),
link_to: getUrlBinaryBot(),
is_external: true,
},
{
name: getPlatformSettingsAppstore('go').name,
app_desc: localize('Trade on the go with our mobile app.'),
app_desc: localize('The mobile trading app for multipliers.'),
link_to: getStaticUrl('/deriv-go'),
is_external: true,
new_tab: true,
Expand All @@ -69,7 +69,7 @@ export const getMFAppstorePlatforms = (): MfPlatformConfig[] => [
app_icon: getPlatformSettingsAppstore('trader').icon,
app_title: getPlatformSettingsAppstore('trader').name,
name: getPlatformSettingsAppstore('trader').name,
app_desc: localize('Multipliers trading platform.'),
app_desc: localize('The multipliers trading platform .'),
mitra-deriv marked this conversation as resolved.
Show resolved Hide resolved
link_to: routes.trade,
},
];
Expand Down
6 changes: 2 additions & 4 deletions packages/core/src/Stores/traders-hub-store.js
Original file line number Diff line number Diff line change
Expand Up @@ -374,13 +374,11 @@ export default class TradersHubStore extends BaseStore {
getAvailableCFDAccounts() {
const getAccountDesc = () => {
return !this.is_eu_user || this.is_demo_low_risk
? localize('This account offers CFDs on financial instruments.')
? localize('CFDs on financial instruments.')
: localize('CFDs on derived and financial instruments.');
};
const getSwapFreeAccountDesc = () => {
return localize(
'Trade swap-free CFDs on MT5 with forex, stocks, stock indices, commodities cryptocurrencies, ETFs and synthetic indices.'
);
return localize('Swap-free CFDs on selected financial and derived instruments.');
};

const all_available_accounts = [
Expand Down
6 changes: 3 additions & 3 deletions packages/shared/src/utils/cfd/available-cfd-accounts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,23 @@ export interface AvailableAccount {
export const getCFDAvailableAccount = () => [
{
name: 'Derived',
description: localize('This account offers CFDs on derived instruments.'),
description: localize('CFDs on derived and financial instruments.'),
platform: CFD_PLATFORMS.MT5,
market_type: 'synthetic',
icon: 'Derived',
availability: 'Non-EU',
},
{
name: 'Deriv X',
description: localize('This account offers CFDs on a highly customisable CFD trading platform.'),
description: localize('CFDs on financial and derived instruments via a customisable platform.'),
platform: CFD_PLATFORMS.DXTRADE,
market_type: 'all',
icon: 'DerivX',
availability: 'Non-EU',
},
{
name: 'Deriv cTrader',
description: localize('This account offers CFDs on a feature-rich trading platform.'),
description: localize('CFDs on financial and derived instruments with copy trading.'),
platform: CFD_PLATFORMS.CTRADER,
market_type: 'all',
icon: 'CTrader',
Expand Down
Loading