Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH-3657] shahzaib / removed tradershub v2 package and ci checks #15437

Conversation

shahzaib-deriv
Copy link
Contributor

@shahzaib-deriv shahzaib-deriv commented May 31, 2024

Changes:

  • Remove Tradershub V2 CI checks
  • Remove Tradershub package from deriv-app repo
  • Tradershub V2 feature flag and routes

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 12, 2024 9:16am

Copy link
Contributor

github-actions bot commented May 31, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15437](https://github.com/binary-com/deriv-app/pull/15437)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-trah-3657-remove-trade-a57941.binary.sx?qa_server=red.derivws.com&app_id=31560
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-trah-3657-remove-trade-a57941.binary.sx
- **App ID**: `31560`

Copy link
Contributor

github-actions bot commented May 31, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 40
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-trah-3657-remove-trade-a57941.binary.sx/

Copy link
Contributor

@mitra-deriv mitra-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚰️ RIP

habib-deriv
habib-deriv previously approved these changes May 31, 2024
Copy link
Contributor

@habib-deriv habib-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

habib-deriv
habib-deriv previously approved these changes Jun 4, 2024
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shahzaib-deriv shahzaib-deriv merged commit 5a6e3f8 into binary-com:master Jun 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants