Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Aizad/Fix Import Issues in Wallets #15495

Merged

Conversation

aizad-deriv
Copy link
Contributor

Changes:

  • Removed unused Import statement inside of AccountFlow.tsx
  • Added ignore eslint in WalletTourGuide.tsx

Screenshots:

image

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 6, 2024 3:40am

Copy link
Contributor

github-actions bot commented Jun 5, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15495](https://github.com/binary-com/deriv-app/pull/15495)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-fix-import-issues-wallets.binary.sx?qa_server=red.derivws.com&app_id=32085
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-fix-import-issues-wallets.binary.sx
- **App ID**: `32085`

Copy link
Contributor

github-actions bot commented Jun 5, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-fix-import-issues-wallets.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 43.295% (+0.001%) from 43.294%
when pulling 6ce804d on aizad-deriv:aizad/fix-import-issues-wallets
into 672615a on binary-com:master.

wojciech-deriv
wojciech-deriv previously approved these changes Jun 5, 2024
@coveralls
Copy link

Coverage Status

coverage: 43.275% (-0.02%) from 43.294%
when pulling 4ffdca7 on aizad-deriv:aizad/fix-import-issues-wallets
into 672615a on binary-com:master.

jim-deriv
jim-deriv previously approved these changes Jun 5, 2024
nijil-deriv
nijil-deriv previously approved these changes Jun 5, 2024
wojciech-deriv
wojciech-deriv previously approved these changes Jun 5, 2024
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 43.27% (-0.001%) from 43.271%
when pulling 802b4f2 on aizad-deriv:aizad/fix-import-issues-wallets
into dc78fdc on binary-com:master.

@nijil-deriv nijil-deriv merged commit f762463 into binary-com:master Jun 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants