Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH] Sergei / TRAH - 3679 / Add a full screen modal after Sign up - to allow users to go to demo or proceed with real account creation #15758

Merged

Conversation

sergei-deriv
Copy link
Contributor

@sergei-deriv sergei-deriv commented Jun 24, 2024

Changes:

  • create SetupRealAccountOrGoToDemoModal component
  • create AfterSignupFlow component
  • add Analytics for modal open and CTA
  • add unit tests for all created components

Screenshots:

image image image image image

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 12, 2024 9:32am

Copy link
Contributor

github-actions bot commented Jun 24, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15758](https://github.com/binary-com/deriv-app/pull/15758)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-trah-3679modal-af-598d93.binary.sx?qa_server=red.derivws.com&app_id=23835
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-trah-3679modal-af-598d93.binary.sx
- **App ID**: `23835`

Copy link
Contributor

github-actions bot commented Jun 24, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-trah-3679modal-af-598d93.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 45.41% (-0.01%) from 45.424%
when pulling 9a2398c on sergei-deriv:sergei/trah-3679/modal-after-signup
into 8f7de08 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.411% (-0.01%) from 45.424%
when pulling 9a2398c on sergei-deriv:sergei/trah-3679/modal-after-signup
into 8f7de08 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.407% (-0.02%) from 45.424%
when pulling 9a2398c on sergei-deriv:sergei/trah-3679/modal-after-signup
into 8f7de08 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.41% (-0.01%) from 45.424%
when pulling 79252d7 on sergei-deriv:sergei/trah-3679/modal-after-signup
into 8f7de08 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.429% (+0.005%) from 45.424%
when pulling 79252d7 on sergei-deriv:sergei/trah-3679/modal-after-signup
into 8f7de08 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.556% (+0.03%) from 45.524%
when pulling 2f80792 on sergei-deriv:sergei/trah-3679/modal-after-signup
into 2009d9c on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.558% (+0.03%) from 45.524%
when pulling 2f80792 on sergei-deriv:sergei/trah-3679/modal-after-signup
into 2009d9c on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.477% (-0.05%) from 45.524%
when pulling c8048df on sergei-deriv:sergei/trah-3679/modal-after-signup
into 2009d9c on binary-com:master.

@coveralls
Copy link

coveralls commented Jul 12, 2024

Coverage Status

coverage: 45.47% (+0.04%) from 45.434%
when pulling 7ac2421 on sergei-deriv:sergei/trah-3679/modal-after-signup
into e4c3333 on binary-com:master.

@habib-deriv habib-deriv merged commit 78a22e0 into binary-com:master Jul 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants