-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRAH] Sergei / TRAH - 3679 / Add a full screen modal after Sign up - to allow users to go to demo or proceed with real account creation #15758
Merged
habib-deriv
merged 14 commits into
binary-com:master
from
sergei-deriv:sergei/trah-3679/modal-after-signup
Jul 19, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-deriv
requested review from
ali-hosseini-deriv,
matin-deriv,
maryia-deriv and
nijil-deriv
as code owners
June 24, 2024 14:16
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-trah-3679modal-af-598d93.binary.sx/ |
sergei-deriv
force-pushed
the
sergei/trah-3679/modal-after-signup
branch
from
June 27, 2024 15:21
eab7a54
to
2f80792
Compare
yauheni-deriv
approved these changes
Jul 1, 2024
mitra-deriv
reviewed
Jul 3, 2024
packages/appstore/src/components/after-signup-flow/after-signup-flow.tsx
Show resolved
Hide resolved
mitra-deriv
approved these changes
Jul 4, 2024
…modal-after-signup
habib-deriv
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
SetupRealAccountOrGoToDemoModal
componentAfterSignupFlow
componentAnalytics
for modal open and CTAScreenshots: