Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTRA] Maryia/DTRA-1336/feat: update chart 'Interval duration' setting #15877

Conversation

maryia-deriv
Copy link
Contributor

@maryia-deriv maryia-deriv commented Jul 1, 2024

Changes:

  • to display information message and disable 'Interval duration' in chart settings when it's not visible for 1 Tick interval.
  • to cover the change with unit-tests.

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 1, 2024 1:22pm

Copy link
Contributor

github-actions bot commented Jul 1, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15877](https://github.com/binary-com/deriv-app/pull/15877)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-deriv-maryia-dtra-1336interval-e1afe2.binary.sx?qa_server=red.derivws.com&app_id=23880
    - **Original**: https://deriv-app-git-fork-maryia-deriv-maryia-dtra-1336interval-e1afe2.binary.sx
- **App ID**: `23880`

Copy link
Contributor

github-actions bot commented Jul 1, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-maryia-deriv-maryia-dtra-1336interval-e1afe2.binary.sx/

@maryia-deriv maryia-deriv marked this pull request as ready for review July 1, 2024 12:27
@coveralls
Copy link

Coverage Status

coverage: 45.402% (+0.001%) from 45.401%
when pulling 505dd7c on maryia-deriv:maryia/DTRA-1336/interval-duration-description
into b12af3e on binary-com:master.

@balakrishna-deriv balakrishna-deriv merged commit c5fa987 into binary-com:master Jul 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants