Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2PS] - Nada/2570/fix payment method checkbox issue, condition issue #15980

Merged

Conversation

nada-deriv
Copy link
Contributor

@nada-deriv nada-deriv commented Jul 8, 2024

Changes:

  1. From my counterparties list -> when try to place sell order from the advertiser page, the checkbox for the PM is missing (but it is clickable) - issue fixed

  2. From share my ads (sell ad) -> for the PM description, its showing To place an order, add one of the advertiser's preferred payment methods: instead of You may choose up to 3.

Screenshots:

  1. Screen.Recording.2024-07-05.at.5.18.09.PM.mov
  2. Screen.Recording.2024-07-05.at.5.39.24.PM.mov

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 26, 2024 5:59am

Copy link
Contributor

github-actions bot commented Jul 8, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15980](https://github.com/binary-com/deriv-app/pull/15980)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-2570pm-issue-sell-form.binary.sx?qa_server=red.derivws.com&app_id=31586
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-2570pm-issue-sell-form.binary.sx
- **App ID**: `31586`

Copy link
Contributor

github-actions bot commented Jul 8, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-2570pm-issue-sell-form.binary.sx/

@coveralls
Copy link

coveralls commented Jul 8, 2024

Coverage Status

coverage: 46.225% (-0.004%) from 46.229%
when pulling d1f0d36 on nada-deriv:nada/P2PS-2570/pm-issue-sell-form
into a1b3680 on binary-com:master.

Comment on lines 138 to 140
{(active_index === 2 ||
active_index === 0 ||
(active_index === 3 && buy_sell_store.show_advertiser_page)) && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are not calling this component in orders page, can you please check if we can remove this condition instead?

Copy link

sonarcloud bot commented Jul 26, 2024

Copy link
Contributor

Generating Lighthouse report...

@farrah-deriv farrah-deriv merged commit f4237d1 into binary-com:master Jul 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants