-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P2PS] - Nada/2570/fix payment method checkbox issue, condition issue #15980
[P2PS] - Nada/2570/fix payment method checkbox issue, condition issue #15980
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-2570pm-issue-sell-form.binary.sx/ |
{(active_index === 2 || | ||
active_index === 0 || | ||
(active_index === 3 && buy_sell_store.show_advertiser_page)) && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are not calling this component in orders page, can you please check if we can remove this condition instead?
Quality Gate passedIssues Measures |
⏳ Generating Lighthouse report... |
Changes:
From my counterparties list -> when try to place sell order from the advertiser page, the checkbox for the PM is missing (but it is clickable) - issue fixed
From share my ads (sell ad) -> for the PM description, its showing To place an order, add one of the advertiser's preferred payment methods: instead of You may choose up to 3.
Screenshots:
Screen.Recording.2024-07-05.at.5.18.09.PM.mov
Screen.Recording.2024-07-05.at.5.39.24.PM.mov