Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPM-1260]Amina/fix: reset_password_modal_in_logged_in_state #16061

Conversation

amina-deriv
Copy link
Contributor

@amina-deriv amina-deriv commented Jul 14, 2024

Changes:

In logged in state, the condition for triggering the reset password modal is getting overlapped with conditions for other modals.

Screenshots:

Please provide some screenshots of the change.

@boring-cyborg boring-cyborg bot added the Core label Jul 14, 2024
Copy link

vercel bot commented Jul 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 17, 2024 8:26am

Copy link
Contributor

github-actions bot commented Jul 14, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16061](https://github.com/binary-com/deriv-app/pull/16061)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-fixresetpasswordmod-24d537.binary.sx?qa_server=red.derivws.com&app_id=38672
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-fixresetpasswordmod-24d537.binary.sx
- **App ID**: `38672`

Copy link
Contributor

github-actions bot commented Jul 14, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-fixresetpasswordmod-24d537.binary.sx/

@coveralls
Copy link

coveralls commented Jul 14, 2024

Coverage Status

coverage: 45.818% (+0.04%) from 45.783%
when pulling 5fde589 on amina-deriv:amina/fix_reset_password_modal_in_logged_in_state
into e5a76ca on binary-com:master.

@amina-deriv amina-deriv changed the title [WIP]Amina/fix: reset_password_modal_in_logged_in_state [/UPM-1260]Amina/fix: reset_password_modal_in_logged_in_state Jul 15, 2024
@amina-deriv amina-deriv changed the title [/UPM-1260]Amina/fix: reset_password_modal_in_logged_in_state [UPM-1260]Amina/fix: reset_password_modal_in_logged_in_state Jul 15, 2024
@amina-deriv amina-deriv marked this pull request as ready for review July 15, 2024 13:53
Copy link
Contributor

Generating Lighthouse report...

@amina-deriv amina-deriv merged commit c3f3f9c into binary-com:master Jul 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants