-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPM-1260]Amina/fix: reset_password_modal_in_logged_in_state #16061
Merged
amina-deriv
merged 16 commits into
binary-com:master
from
amina-deriv:amina/fix_reset_password_modal_in_logged_in_state
Jul 19, 2024
Merged
[UPM-1260]Amina/fix: reset_password_modal_in_logged_in_state #16061
amina-deriv
merged 16 commits into
binary-com:master
from
amina-deriv:amina/fix_reset_password_modal_in_logged_in_state
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-fixresetpasswordmod-24d537.binary.sx/ |
…ix_reset_password_modal_in_logged_in_state
amina-deriv
changed the title
[WIP]Amina/fix: reset_password_modal_in_logged_in_state
[/UPM-1260]Amina/fix: reset_password_modal_in_logged_in_state
Jul 15, 2024
amina-deriv
changed the title
[/UPM-1260]Amina/fix: reset_password_modal_in_logged_in_state
[UPM-1260]Amina/fix: reset_password_modal_in_logged_in_state
Jul 15, 2024
amina-deriv
requested review from
ali-hosseini-deriv,
matin-deriv,
maryia-deriv and
nijil-deriv
as code owners
July 15, 2024 13:53
…ix_reset_password_modal_in_logged_in_state
⏳ Generating Lighthouse report... |
likhith-deriv
approved these changes
Jul 17, 2024
utkarsha-deriv
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
In logged in state, the condition for triggering the reset password modal is getting overlapped with conditions for other modals.
Screenshots:
Please provide some screenshots of the change.