Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nijil / WALL-4502 / Wallet upgrade banner UI fixes for Tablet screen sizes #16199

Conversation

nijil-deriv
Copy link
Contributor

@nijil-deriv nijil-deriv commented Jul 25, 2024

Changes:

Wallet migration banner in TH for Tablet screen sizes UI enhancements with updated design for better client experience.

Dimensions

  • Mobile/smaller screen tablets screen width <= 600 pixels.
  • Tablets/larger screen phones/small screen desktops screen width >= 601px <= 1279 pixels.
  • Desktop/larger screen tablets screen width >= 1280 pixels.

Screen Recording:

Screen.Recording.2024-07-26.at.12.01.35.mov

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 1, 2024 2:38pm

Copy link
Contributor

github-actions bot commented Jul 25, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16199](https://github.com/binary-com/deriv-app/pull/16199)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nijil-deriv-nijil-wall-4502wallet-ban-8da2c1.binary.sx?qa_server=red.derivws.com&app_id=38677
    - **Original**: https://deriv-app-git-fork-nijil-deriv-nijil-wall-4502wallet-ban-8da2c1.binary.sx
- **App ID**: `38677`

Copy link
Contributor

github-actions bot commented Jul 25, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-nijil-deriv-nijil-wall-4502wallet-ban-8da2c1.binary.sx/

@coveralls
Copy link

coveralls commented Jul 25, 2024

Coverage Status

coverage: 46.546% (+0.003%) from 46.543%
when pulling f4a3006 on nijil-deriv:nijil/wall-4502/wallet-banner-tablet
into 1094e9e on binary-com:master.

wojciech-deriv
wojciech-deriv previously approved these changes Jul 25, 2024
jim-deriv
jim-deriv previously approved these changes Jul 26, 2024
Copy link

sonarcloud bot commented Aug 1, 2024

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit a120f83 into binary-com:master Aug 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants