Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rupato/BOT-2004/fix: refactored bot functions #16230

Conversation

rupato-deriv
Copy link
Contributor

Refactored the bot importing functions

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 26, 2024 10:27am

Copy link
Contributor

github-actions bot commented Jul 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16230](https://github.com/binary-com/deriv-app/pull/16230)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-bot-2004-refactor-081fc3.binary.sx?qa_server=red.derivws.com&app_id=32109
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-bot-2004-refactor-081fc3.binary.sx
- **App ID**: `32109`

Copy link
Contributor

github-actions bot commented Jul 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 32
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-bot-2004-refactor-081fc3.binary.sx/

farabi-deriv
farabi-deriv previously approved these changes Aug 26, 2024
farabi-deriv
farabi-deriv previously approved these changes Aug 26, 2024
farabi-deriv
farabi-deriv previously approved these changes Aug 26, 2024
sandeep-deriv
sandeep-deriv previously approved these changes Aug 26, 2024
Copy link

sonarcloud bot commented Aug 26, 2024

Copy link
Contributor

Generating Lighthouse report...

@farabi-deriv farabi-deriv merged commit 3dec78b into binary-com:master Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants