henry/dtra-1563/fix: asset/symbol selection bug fix

[henry-deriv]

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Aug 14, 2024 8:30am

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: henry/dtra-1563/fix: asset/symbol selection bug fix #16333
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-henry-deriv-henry-dtra-1563dtra-v2-sy-0a7a03.binary.sx?qa_server=red.derivws.com&app_id=32227
  • Original: https://deriv-app-git-fork-henry-deriv-henry-dtra-1563dtra-v2-sy-0a7a03.binary.sx
• App ID: 32227

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/16333](https://github.com/binary-com/deriv-app/pull/16333)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-henry-deriv-henry-dtra-1563dtra-v2-sy-0a7a03.binary.sx?qa_server=red.derivws.com&app_id=32227
    - **Original**: https://deriv-app-git-fork-henry-deriv-henry-dtra-1563dtra-v2-sy-0a7a03.binary.sx
- **App ID**: `32227`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	27
🟧 Accessibility	70
🟧 Best practices	83
🟧 SEO	77
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-fork-henry-deriv-henry-dtra-1563dtra-v2-sy-0a7a03.binary.sx/

[coveralls]

coverage: 46.908% (+0.04%) from 46.865%
when pulling 140a3d6 on henry-deriv:henry/dtra-1563/dtra-v2-symbol-selector-fix
into 6af2bc1 on binary-com:master.

[kate-deriv]

We have isDTraderV2 function in shared. It checked localstorage and innerWidth. Can it be reused? Or modified?

[henry-deriv]

im seeing instances where pathnames are checked individually

isDTraderV2() && !is_contract_details

OR

if (isDTraderV2())
            return (
                <Loading.DTraderV2
                    initial_app_loading
                    is_contract_details={location.pathname.startsWith('/contract/')}
                    is_positions={location.pathname === routes.trader_positions}
                    is_closed_tab={getPositionsV2TabIndexFromURL() === 1}
                />
            );
            
            
if (is_positions)
        return <PositionsLoader initial_app_loading={initial_app_loading} is_closed_tab={is_closed_tab} />;
if (is_contract_details) return <ContractDetailsLoader />;

so if i am to use the the shared function then

where i use this.is_dtrader_v2_enabled it'll be replaced with

isDtraderV2() && (window.location.pathname.startsWith(routes.trade) || window.location.pathname.startsWith('/contract/'))

in two separate places.

[henry-deriv]

slightly messy

[henry-deriv]

at some point we'll likely need some kind of cleanup since this kind of logic with many variations is used in many places.

[kate-deriv]

Okay-okay, no problem)

[sonarcloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud