Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sergei / Move webpack plugins to default plugins #16367

Merged

Conversation

sergei-deriv
Copy link
Contributor

Changes:

Move webpack plugins to default plugins

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 5, 2024 3:06pm

Copy link

sonarcloud bot commented Aug 5, 2024

Copy link
Contributor

github-actions bot commented Aug 5, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16367](https://github.com/binary-com/deriv-app/pull/16367)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-fix-same-plugins.binary.sx?qa_server=red.derivws.com&app_id=30370
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-fix-same-plugins.binary.sx
- **App ID**: `30370`

Copy link
Contributor

github-actions bot commented Aug 5, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 40
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-fix-same-plugins.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 46.55% (-0.001%) from 46.551%
when pulling ebe56dd on sergei-deriv:sergei/fix-same-plugins
into 335f744 on binary-com:master.

@heorhi-deriv heorhi-deriv merged commit a8ced74 into binary-com:master Aug 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants