Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aswathy/fix: test analytics for country screen #16410

Conversation

aswathy-deriv
Copy link
Contributor

@aswathy-deriv aswathy-deriv commented Aug 8, 2024

Changes:

Country screen data tracking value is coming lesser than that of password screen.This issue is fixed in this PR by creating a cache method for storing the events in the localstorage when the rudderstack is not loaded.

Screenshots:

Please provide some screenshots of the change.

@boring-cyborg boring-cyborg bot added the Core label Aug 8, 2024
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 14, 2024 8:51am

Copy link
Contributor

github-actions bot commented Aug 8, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16410](https://github.com/binary-com/deriv-app/pull/16410)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aswathy-deriv-test-analytics-loading-country.binary.sx?qa_server=red.derivws.com&app_id=30371
    - **Original**: https://deriv-app-git-fork-aswathy-deriv-test-analytics-loading-country.binary.sx
- **App ID**: `30371`

Copy link
Contributor

github-actions bot commented Aug 8, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 38
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aswathy-deriv-test-analytics-loading-country.binary.sx/

@coveralls
Copy link

coveralls commented Aug 8, 2024

Coverage Status

coverage: 46.892% (+0.3%) from 46.592%
when pulling f289a02 on aswathy-deriv:test-analytics-loading-country
into 1cb4ca2 on binary-com:master.

Copy link

sonarcloud bot commented Aug 14, 2024

Copy link
Contributor

Generating Lighthouse report...

@ali-hosseini-deriv ali-hosseini-deriv merged commit d1325b6 into binary-com:master Aug 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants