-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aswathy/fix: test analytics for country screen #16410
Aswathy/fix: test analytics for country screen #16410
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-aswathy-deriv-test-analytics-loading-country.binary.sx/ |
packages/core/src/App/Containers/AccountSignupModal/account-signup-modal.jsx
Outdated
Show resolved
Hide resolved
packages/core/src/App/Containers/AccountSignupModal/account-signup-modal.jsx
Outdated
Show resolved
Hide resolved
packages/core/src/App/Containers/AccountSignupModal/account-signup-modal.jsx
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
⏳ Generating Lighthouse report... |
Changes:
Country screen data tracking value is coming lesser than that of password screen.This issue is fixed in this PR by creating a cache method for storing the events in the localstorage when the rudderstack is not loaded.
Screenshots:
Please provide some screenshots of the change.