-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a notification for users to accept the updated T&Cs changes #16422
base: master
Are you sure you want to change the base?
Adding a notification for users to accept the updated T&Cs changes #16422
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-utkarsha-deriv-utkarsha-tncchange.binary.sx/ |
.../src/App/Containers/Modals/tnc-status-update-modal/__test__/tnc-status-update-modal.spec.tsx
Outdated
Show resolved
Hide resolved
.../src/App/Containers/Modals/tnc-status-update-modal/__test__/tnc-status-update-modal.spec.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/App/Containers/Modals/tnc-status-update-modal/tnc-status-update-modal.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/App/Containers/Modals/tnc-status-update-modal/tnc-status-update-modal.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/App/Containers/Modals/tnc-status-update-modal/tnc-status-update-modal.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/App/Containers/Modals/tnc-status-update-modal/tnc-status-update-modal.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/App/Containers/Modals/tnc-status-update-modal/tnc-status-update-modal.tsx
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
⏳ Generating Lighthouse report... |
Changes:
Added a new pop-up notification for users to accept the updated T&Cs changes.
We are getting
tnc_status
in theget_settings
response.This response will now have a hash like this.
"tnc_status": {
"svg": 1/0,
"maltainvest": 1/0
}
The 1 or 0 indicates whether they have accepted the tnc or not. If it is 0 then we need to show the pop up.
Upon accepting, we make an authenticated hit to
tnc_approval
apiThis PR also implement's the T&C acceptance for the new account creation for real, Malta invest. The PR adds a new flag called tnc_acceptance : 1 to new_account_maltainvest and new_account_real api request payload.
Screenshots: