Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a notification for users to accept the updated T&Cs changes #16422

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

utkarsha-deriv
Copy link
Contributor

@utkarsha-deriv utkarsha-deriv commented Aug 8, 2024

Changes:

Added a new pop-up notification for users to accept the updated T&Cs changes.
We are getting tnc_status in the get_settings response.
This response will now have a hash like this.
"tnc_status": {
"svg": 1/0,
"maltainvest": 1/0
}
The 1 or 0 indicates whether they have accepted the tnc or not. If it is 0 then we need to show the pop up.
Upon accepting, we make an authenticated hit to tnc_approval api

This PR also implement's the T&C acceptance for the new account creation for real, Malta invest. The PR adds a new flag called tnc_acceptance : 1 to new_account_maltainvest and new_account_real api request payload.

Screenshots:

Screenshot 2024-08-08 at 6 53 00 PM Screenshot 2024-08-08 at 6 53 13 PM

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 23, 2024 10:46am

Copy link
Contributor

github-actions bot commented Aug 8, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16422](https://github.com/binary-com/deriv-app/pull/16422)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-utkarsha-deriv-utkarsha-tncchange.binary.sx?qa_server=red.derivws.com&app_id=23853
    - **Original**: https://deriv-app-git-fork-utkarsha-deriv-utkarsha-tncchange.binary.sx
- **App ID**: `23853`

Copy link
Contributor

github-actions bot commented Aug 8, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-utkarsha-deriv-utkarsha-tncchange.binary.sx/

likhith-deriv
likhith-deriv previously approved these changes Aug 9, 2024
@coveralls
Copy link

coveralls commented Aug 9, 2024

Coverage Status

coverage: 52.386% (-0.001%) from 52.387%
when pulling ad24108 on utkarsha-deriv:utkarsha/tnc_change
into 2f79fe8 on binary-com:master.

amina-deriv
amina-deriv previously approved these changes Sep 13, 2024
Copy link

sonarcloud bot commented Sep 18, 2024

Copy link

sonarcloud bot commented Sep 23, 2024

Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants