Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rupato/bot 2098/fix delete and zoom after blockly update #16436

Conversation

rupato-deriv
Copy link
Contributor

Changed the return type of the method to false after the block is dragged from the flyout. Because other events do not trigger unless this is set to false. The method returns true while the block is being dragged from the flyout.

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 13, 2024 4:46am

Copy link
Contributor

github-actions bot commented Aug 12, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16436](https://github.com/binary-com/deriv-app/pull/16436)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-bot-2098fix-delet-71151a.binary.sx?qa_server=red.derivws.com&app_id=38674
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-bot-2098fix-delet-71151a.binary.sx
- **App ID**: `38674`

Copy link
Contributor

github-actions bot commented Aug 12, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 37
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-bot-2098fix-delet-71151a.binary.sx/

@coveralls
Copy link

coveralls commented Aug 12, 2024

Coverage Status

coverage: 46.852% (+0.05%) from 46.799%
when pulling 5d13edb on rupato-deriv:Rupato/BOT-2098/Fix-delete-and-zoom-after-blockly-update
into a3da32a on binary-com:master.

Copy link

sonarcloud bot commented Aug 13, 2024

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Generating Lighthouse report...

@farabi-deriv farabi-deriv merged commit 7569ae1 into binary-com:master Aug 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants