Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT] Farabi/bot-2133/show-proper-message-on-loading-invalid-strategy #16527

Conversation

farabi-deriv
Copy link
Contributor

Changes:

  • To show an error message clearly stating that the strategy file you attempted to upload is invalid. Please check the file format and completeness, and try again.

Screenshots:

Screenshot 2024-08-19 at 12 41 16 PM

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 26, 2024 6:58am

Copy link
Contributor

github-actions bot commented Aug 19, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16527](https://github.com/binary-com/deriv-app/pull/16527)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-2133show-prop-173622.binary.sx?qa_server=red.derivws.com&app_id=32877
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-2133show-prop-173622.binary.sx
- **App ID**: `32877`

Copy link
Contributor

github-actions bot commented Aug 19, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 32
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-2133show-prop-173622.binary.sx/

@coveralls
Copy link

coveralls commented Aug 19, 2024

Coverage Status

coverage: 46.787% (+0.7%) from 46.058%
when pulling c825ea9 on farabi-deriv:farabi/bot-2133/show-proper-message-on-loading-invalid-strategy
into 0415d09 on binary-com:master.

sandeep-deriv
sandeep-deriv previously approved these changes Aug 19, 2024
rupato-deriv
rupato-deriv previously approved these changes Aug 19, 2024
Copy link

sonarcloud bot commented Aug 26, 2024

@farabi-deriv farabi-deriv merged commit 11d85fa into binary-com:master Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants