Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPM-1303]/evgeniy/livechat name and email not populated #16676

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

yauheni-deriv
Copy link
Contributor

@yauheni-deriv yauheni-deriv commented Aug 29, 2024

Changes:

  1. removed unnecessary dependancy from package.json (@livechat/customer-sdk) as it is not used.
  2. refactored the logic to initialise livechat, as previously it was in the hook which is called in ui component.
  3. remove legacy LC_API
  4. added the logic to hide livechat widget during log out and log in, as the state inside livechat (name and email) updates only with closing and reopening livechat
  5. make initialisation only when remote config flag is true and client store is initialised
  6. hide small red LC widget on responsive, as it is not expected to appear (it appears now when you refresh the page with opened livechat)
  7. modified whatsapp component to be more reusable
  8. added hooks for initialisation of livechat and to check when it is ready
  9. added types to livechat

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 23, 2024 11:57am

heorhi-deriv
heorhi-deriv previously approved these changes Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16676](https://github.com/binary-com/deriv-app/pull/16676)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yauheni-deriv-livechat-upm-1303-namea-9f4db1.binary.sx?qa_server=red.derivws.com&app_id=23851
    - **Original**: https://deriv-app-git-fork-yauheni-deriv-livechat-upm-1303-namea-9f4db1.binary.sx
- **App ID**: `23851`

Copy link
Contributor

github-actions bot commented Aug 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-yauheni-deriv-livechat-upm-1303-namea-9f4db1.binary.sx/

@coveralls
Copy link

coveralls commented Aug 29, 2024

Coverage Status

coverage: 52.425% (+0.04%) from 52.387%
when pulling 70bb92f on yauheni-deriv:livechat/upm-1303-name_and_email_not_populated
into 980d9bd on binary-com:master.

Copy link

sonarcloud bot commented Sep 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.