[CFDS] shontzu/CFDS-4498/british-pound-sign-is-not-accepted-as-a-special-character

[shontzu-deriv]

Changes:

• slack
• figma

Screenshots:

Please provide some screenshots of the change.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Sep 13, 2024 10:23am

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: [CFDS] shontzu/CFDS-4498/british-pound-sign-is-not-accepted-as-a-special-character #16691
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-4498britis-cec59f.binary.sx?qa_server=red.derivws.com&app_id=24101
  • Original: https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-4498britis-cec59f.binary.sx
• App ID: 24101

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/16691](https://github.com/binary-com/deriv-app/pull/16691)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-4498britis-cec59f.binary.sx?qa_server=red.derivws.com&app_id=24101
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-4498britis-cec59f.binary.sx
- **App ID**: `24101`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	35
🟧 Accessibility	70
🟢 Best practices	92
🟧 SEO	77
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-4498britis-cec59f.binary.sx/

[coveralls]

coverage: 51.819% (+0.02%) from 51.799%
when pulling bb5d16a on shontzu-deriv:shontzu/CFDS-4498/british-pound-sign-is-not-accepted-as-a-special-character
into 6590a0e on binary-com:master.

[matin-deriv]

@shontzu-deriv I don't believe this is the most effective approach to resolving the issue, as it specifically targets the British pound symbol.

I suggest using a list of valid characters and disregarding any others for a more generic solution!

[shontzu-deriv]

@shontzu-deriv I don't believe this is the most effective approach to resolving the issue, as it specifically targets the British pound symbol.

I suggest using a list of valid characters and disregarding any others for a more generic solution!

pushed a revised fix @matin-deriv

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud