Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ako/ CRO-724/ Pass growthbook attributes on initialisation #16713

Merged
merged 12 commits into from
Sep 6, 2024
Merged

Ako/ CRO-724/ Pass growthbook attributes on initialisation #16713

merged 12 commits into from
Sep 6, 2024

Conversation

ali-hosseini-deriv
Copy link
Member

@ali-hosseini-deriv ali-hosseini-deriv commented Sep 3, 2024 •
edited
Loading

Changes:

This is to ensure we initialise the rudderstack and growthbook at the same time. which will fix the Growthbook Experiments issue.
We also dont need to pass the country location from initialise function anymore as it will picked up automatically on analytics package.

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 4, 2024 8:45am

@ali-hosseini-deriv ali-hosseini-deriv changed the title Ako/ CRO-724 Use analytics v1.14 Ako/ CRO-724/ Use analytics v1.14 Sep 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/16713](https://github.com/binary-com/deriv-app/pull/16713)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-cro-724use-ana-aaa8a1.binary.sx?qa_server=red.derivws.com&app_id=23880
    - **Original**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-cro-724use-ana-aaa8a1.binary.sx
- **App ID**: `23880`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-ako-cro-724use-ana-aaa8a1.binary.sx/

amam-deriv
amam-deriv previously approved these changes Sep 3, 2024
View reviewed changes
Copy link

@amam-deriv amam-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

packages/core/src/Utils/Analytics/index.ts Outdated
@@ -1,5 +1,5 @@
import { Analytics } from '@deriv-com/analytics';
import Cookies from 'js-cookie';
import * as Cookies from 'js-cookie';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] do we use all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually Not needed. let me remove it

@ali-hosseini-deriv ali-hosseini-deriv changed the title Ako/ CRO-724/ Use analytics v1.14 Ako/ CRO-724/ Use analytics v1.15 Sep 3, 2024
@ali-hosseini-deriv ali-hosseini-deriv changed the title Ako/ CRO-724/ Use analytics v1.15 Ako/ CRO-724/ Use analytics pass the growthbook attributes on initialisation Sep 3, 2024
@ali-hosseini-deriv ali-hosseini-deriv changed the title Ako/ CRO-724/ Use analytics pass the growthbook attributes on initialisation Ako/ CRO-724/ Pass growthbook attributes on initialisation Sep 3, 2024
sandeep-deriv
sandeep-deriv previously approved these changes Sep 4, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rupato-deriv rupato-deriv merged commit d3b3292 into binary-com:master Sep 6, 2024
8 checks passed
rupato-deriv pushed a commit that referenced this pull request Sep 6, 2024
@ali-hosseini-deriv @rupato-deriv
Ako/ CRO-724/ Pass growthbook attributes on initialisation (#16713)
eab202d 
* build: update analytics to ver 1.13.0

* build: update to version 1.14

* feat: add user_id only if its available

* test: fix analytics test cases

* feat: pass the attributes on GB initialisation

* build: match the js-cookie types with the package version

* fix: remove country property as its built in to the analytics package

* build: update to 1.15.0 to also include changes for the new location implementation

* chore: revert the icons file changes

* Revert "build: update to 1.15.0 to also include changes for the new location implementation"

This reverts commit 67445cb.

* Revert "fix: remove country property as its built in to the analytics package"

This reverts commit e8dcc9e.

* chore: change import statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

@sandeep-deriv sandeep-deriv sandeep-deriv approved these changes

@aswathy-deriv aswathy-deriv aswathy-deriv approved these changes

@amam-deriv amam-deriv amam-deriv approved these changes

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv adrienne-deriv is a code owner

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv thisyahlen-deriv is a code owner

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

@amina-deriv amina-deriv Awaiting requested review from amina-deriv amina-deriv is a code owner

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@hirad-deriv hirad-deriv Awaiting requested review from hirad-deriv hirad-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@aizad-deriv aizad-deriv Awaiting requested review from aizad-deriv aizad-deriv is a code owner

@heorhi-deriv heorhi-deriv Awaiting requested review from heorhi-deriv heorhi-deriv is a code owner

Assignees
No one assigned
Labels
Account AppStore Components Core P2P Shared Trader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ali-hosseini-deriv @coveralls @balakrishna-deriv @sandeep-deriv @aswathy-deriv @amam-deriv @rupato-deriv