Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPM-1474]/evgeniy/passkey remove without verification #16764

Merged
merged 20 commits into from
Sep 18, 2024
Merged

[UPM-1474]/evgeniy/passkey remove without verification #16764

merged 20 commits into from
Sep 18, 2024

Conversation

yauheni-deriv
Copy link
Contributor

@yauheni-deriv yauheni-deriv commented Sep 6, 2024 •
edited
Loading

Changes:

  1. Implemented the flow for removing passkey without verification: components and API hook.
  2. Refactored register and rename hooks to accept onSuccess function. It allowed to refactor passkeys.tsx and remove unnecessary useEffects.
  3. removed import React from 'react'
  4. tracking error moved outside of API hooks
  5. added tracking events
  6. added lazyl oading for passkeys menu to reduce the initial loaded account package size
  7. translation changed to @deriv-com/translations

Screenshots:

Screenshot 2024-09-09 at 13 01 01 Screenshot 2024-09-09 at 13 00 55

@boring-cyborg boring-cyborg bot added the Account label Sep 6, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 18, 2024 5:59am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/16764](https://github.com/binary-com/deriv-app/pull/16764)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yauheni-deriv-passkey-remove-without-6ded4c.binary.sx?qa_server=red.derivws.com&app_id=32820
    - **Original**: https://deriv-app-git-fork-yauheni-deriv-passkey-remove-without-6ded4c.binary.sx
- **App ID**: `32820`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-yauheni-deriv-passkey-remove-without-6ded4c.binary.sx/

@coveralls
Copy link

coveralls commented Sep 9, 2024 •
edited
Loading

Coverage Status

coverage: 52.229% (-0.01%) from 52.242%
when pulling 2ed39d0 on yauheni-deriv:passkey-remove-without-verification
into 388e5ee on binary-com:master.

amina-deriv
amina-deriv previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@amina-deriv amina-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

@amina-deriv amina-deriv merged commit 97eb8c6 into binary-com:master Sep 18, 2024
8 checks passed
amina-deriv added a commit that referenced this pull request Sep 18, 2024
@amina-deriv @yauheni-deriv @heorhi-deriv
update master (#16881)
6672c90 
* [UPM-1474]/evgeniy/passkey remove without verification (#16764)

* chore: [UPM-1474]/evgeniy/passkey remove without verification

* fix: import and typo

* fix: error modal overlapping, no paskey page show when no passkey after removing

* chore: test cases

* refactor: remove usequery from getpasskeys

* fix: failing test

* fix: failing tests

* fix: test

* fix: wrong condition to save empty passkey array

* feat(cashier): ✨ support crypto withdrawal transaction redirection from deriv go (#16802)

---------

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>
Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amina-deriv amina-deriv amina-deriv approved these changes

@fasihali-deriv fasihali-deriv fasihali-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

Assignees
No one assigned
Labels
Account Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yauheni-deriv @coveralls @amina-deriv @fasihali-deriv