Ahmad/Trade Spec fix #16797
Merged
Ahmad/Trade Spec fix #16797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadtaimoor-deriv
requested review from
matin-deriv and
maryia-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ahmadtaimoor-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
aizad-deriv
approved these changes
Sep 11, 2024
balakrishna-deriv
approved these changes
Sep 11, 2024
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-ahmadtaimoor-deriv-ftradespecfix.binary.sx/ |
amina-deriv
added a commit
that referenced
this pull request
Sep 13, 2024
* [CFDS]/Hasan/CFDS-4247/Zero Spread MT5 for Desktop and Responsive in Wallets (#16388) * feat: updated useSortedMT5Accounts to include zero spread * fix: renamed variable name to be consistant * fix: add early return to look cool * feat: added zero spread title * fix: useSortedMT5Accounts for added accounts * feat: added zero spread content * feat: added new badge * feat: added zero spread in compare table * fix: prettier fix in InstrumentsIconWithLabel * feat: added verification flow and fix AvailableMT5AccountsList types * fix: removed unnecessary isRequired props from tax residance dropdown from personal details * fix: fixed react render error * feat: updated password modal design for desktop * feat: updated password modal design for mobile * fix: removed commented css * feat: create mt5 create password * fix: revert create password * fix: fixed mt5 create password screen * fix: fixed mt5 create password screen * fix: added mt5 create password screen to mt5 password modal * fix: fixed css and classNames * feat: added tnc check * fix: fixed condition and types * fix: tnc text and verification flow passwordModal * fix: added product, platform and company content * fix: tncUrl link * fix: change sub_account_category to product in createMT5AccountMutate * feat: added zero spread content to success modal * feat: added tnc component * feat: added tnc to enter password component and updated enter password component css and content * fix: tnc css * feat: added tnc check to enter password modal's button * feat: added logged in content for zero spread * feat: added wallet badge component * feat: added badge to MT5TradeScreen and AddedMT5AccountsList component * feat: added zero spread title to cashier * feat: added zero spread compare card for demo * feat: enter password modal content for demo * feat: demo account creation * feat: update demo success content * fix: fixed client verification * fix: fixed setState error * fix: space issue in success modal * fix: useEffect errror * fix: memory leak issue * fix: remove sub_accout_type type * fix: remove sub_accout_type type * feat: added badge test cases * feat: added lazy loading to client verification modal * fix: MT5AccountAdded test cases * feat: added CFDPasswordModalTn test cases * fix: ClientVerification onComplete call * fix: useSortedMT5Accounts sorting to show zero spread last * fix: updated wallet badge snapshot test * feat: added zero speread icon to wallet icon * feat: passed product to wallet icon * fix: fixed design issues * feat: add new condition for swap free password modal * feat: add new condition for swap free password modal * fix: remove wallet badge's snapshot test * fix: CompareAccountsDescription typescript issue * fix: CompareAccountsTitleIcon test cases * fix: CompareAccountsTitleIcon test cases * fix: WalletBadge test cases * fix: demo password modal tnc condition * fix: added Localise * fix: removed isMounted from Poa * fix: resolved pr comments * fix: build and test failing * fix: change walletText to Text component * fix: resolved comments * fix: fixed password modal button text size * fix: fixed failed test * fix: fixed MT5ChangePasswordScreens failed test * fix: fixed compare accounts table * fix: added title to document selection modal * fix: fixed tnc text * fix: CompareAccountsCard test * fix: CompareAccountsCard title icon * fix: fixed compare table design * fix: added title to onfido modal * fix: added title to onfido modal * fix: removed jurisdiction badge from AddedMT5AccountsList * fix: added zero spread icon support in transaction * fix: fixed transaction icon and title * chore: remove (!) exclamation mark from NEW badge on logout screen --------- Co-authored-by: shontzu-deriv <shon.tzu@regentmarkets.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> * DTRA-1855 / Kate / [DTrader-V2]: Change chart height calculations based on the latest design (#16773) * refactor: update chart height calculations * refactor: add tests * [DTRA]/Ahmad/Duration Fixes (#16744) * fix: fix * chore: fix * chore: new fixes * fix: fix * fix: fix the animation and scrolling behavior in step 4 for trade page onboarding (#16777) * [DTRA-V2]fix: contract details scroll (#16762) * fix: contract details scroll * fix: contract details scroll * fix: contract details scroll by adjusting the height of container * fix: contract details scroll by adjusting the height of container * fix: adjust contract-details page to take up the whole height * fix: added padding bottom for contracts detail page for the scroll to work in mobile * aum / WALL-4754 / fix-console-error-for-poa-and-tax-info (#16523) * fix: react error on unmount of Poa.tsx * fix: state update after unmount in DocumentSubmission.tsx of POA * [CFDS]/hasan/CFDS-4263/Refactor JS components to TS (#16507) * feat: refactor success dialog * fix: fixed typescript error in test cases * feat: refactor error component * feat: refactor error component * feat: refactor inverstor password manager component * feat: remove unused loading component * fix: fixed error component typescript issue * fix: removed link component and it's helpers function * fix: converted routes and binary routes to ts * fix: removed unnecessary props * feat: convert 404 page int TS * feat: added types to work on route config * feat: convert routes-config to TS * feat: convert routes component to TS * fix: fixed Error Component according to Routes component * fix: missing imports * feat: convert route-with-sub-routes to TS * fix: fixed build errors * feat: removed prop types package * fix: fixed failed import in cfd top up demo modal * feat: added test to binary routes * feat: added test to route with subroute component * fix: route-with-sub-route test cases * feat: added routes test cases * feat: added cfd-password-success-message test cases * fix: added passthrough to routes --------- Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> * DTRA-1815 / Kate / [DTrader-V2]: Add Onboarding video for Draggable component (Trade types selection) (#16759) * refactor: prepare folder structure * refactor: change structure of flags on clocalstorage * chore: remove code smells * refactor: create reusable stream iframe component * refactor: add tests * chore: remove coed smalls * refactor: add id for teh video * refactor: apply suggestions * chore: remove extra waitfor in tests * chore: fix test case * DTRA-1846 / Kate / Hide purchase button when the market is closed (#16772) * fix: add condition for rendering purchase button * refactor: removed unused * chore: ui issue * fix: fix (#16797) * fix: adding is dbot to every strategy action (#16768) * [BOT] Farabi/bot-1488/test-coverage-for-qs-selects (#16774) * chore: increased test coverage for symbol * chore: increase coverage for rest of files in selects folder * fix: reverted the component change and utilized from test case * chore: remove user event click since user event type is being used * [WALL] aum / WALL-4673 / tax-info-hide-tin-field-for-not-mandatory-jurisdictions (#16695) * feat: hide tin field for tin not mandatory countries * fix: remove fallback for selectedJurisdiction prop of TaxInformation * Rupato/BOT-2099/Blockly icon are not shown upon collapsing blocks (#16727) * fix: collapsed block * fix: refactored code * fix: refactored code * fix: review comments * fix: review comments * fix: function naming * fix: review comments * fix: removed commented code * fix: added css chanes * fix: trigger cypress * fix: removed console.log from catch * translations: 📚 sync translations with crowdin (#16805) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * [WALL] Aizad/WALL-4573/Tablet View for Wallets (#16173) * chore: remove landscape blocker for Wallets * chore: update Header for Tablet view for Wallets * chore: change CFD and Options scss listing to support tablet view * chore: fix carousel styles for tablet * chore: remove trading account card border bottom for tablet view * chore: updated styles for AddMoreWallets section * chore: replace old mixins with newly updated ones * chore: implement tablet view for fiat wallet cashier * chore: update cashier crypto wallets * chore: update onboarding steps for tablet * chore: update modal for tablet view and mt5 features * chore: implement Tablet view on ChangePassword modals * chore: Enable tablet view for CompareAccount route * chore: fixing header for different platforms * chore: fix WalletClipboard component * chore: fix clipboard component for tablet view * chore: hide scrollbar inside of cashier content * chore: update test for AccountList * chore: fix failing test cases * chore: replace icons with quill icons * chore: minor styles updates * chore: update live chat component * chore: update JurisdictionTncSection styling to fit tablet * chore: update WalletError screen * chore: updated rest of the styles for tablet view * chore: update rest of the screens with Tablet view * chore: update tradershub header menu * fix: resolve comments * chore: update Wallet Modals * chore: fix modal for Jurisdiction Modal * chore: update test cases * chore: remove useDevice hook from wallet package * chore: update styles inside of DatePicker component * chore: fix WalletListHeader test * chore: fix card width inside of Tablet view * chore: maintain same transfer screen in desktop for tablet * chore: update card loader for tablets * chore: update modal put content in the center * chore: update container to align at the top for tablet view * fix: center crypto deposit content inside of cahier * chore: fix failing test cases * fix: crypto withdrawal page * chore: update Text size for wallet action button * chore: fix shadow getting cut off inside cashier content * chore: update EnterPasswordModal * chore: resolve suggestions * chore: resolve comments * chore: resolve comments * chore: resolve comments * fix: rename test file name and solve test case errors * chore: resolve comments * chore: resolve conflicts * chore: update layout for crypto deposit and withdrawal in desktop * chore: update font size for responsive action button * chore: update classnames * chore: update account switcher based on latest tablet design * chore: update stylings for tablet view * fix: test case failing CFDSuccess * fix: typescript issues and broken test cases * fix: fiat-onramp contaier alignment issue * chore: update breakpoints for scss files inside of wallets * fix: layout sizing and change font size inside of crypto widthdrawal * fix: failing test cases * chore: make minor ammendments * chore: update test cases * chore: update sizing inside wallet carousel header * chore: update width for crypto withdrawal * chore: update text sizing for mt5 jurisdiction and createpassword * chore: update jurisdiction layout modal for tablet view * chore: update mt5 password modal tablet view * chore: fix mt5 modals in tablet view * chore: update jurisdiction footer text * chore: update success button width * chore: fix test cases * fix: failing test case for WalletBadge * fix: ammend fail test cases * DTRA/Ahmad/Contract Details For Smart Trader Contract (#16714) * chore: going on * chore: progress * fix: fix * chore: done * fix: fix * chore: testcases * fix: fix * fix: fix * [DTRA-V2] fix: change actionsheet content (#16765) * fix: change actionsheet content * fix: failing test * DTRA-1474 / Kate / Implement Payout per point trade param functionality (#16783) * feat: create payout per point initial component * refactor: add initial values to localstorage * refactor: add tests * refactor: show unchanged value in the trade param * [WALL] george / WALL-4694 / Implement UI components for disabled wallet (#16750) * feat(wallets): ✨ implement WalletDialog component * fix(wallets): 🐛 fix and rename get button * fix(wallets): 🧪 fix broken test * feat(wallets): ✨ add WalletStatusBadge component * refactor(wallets): ♻️ refactor WalletsDialog * [WALL] Aizad/WALL-4690/Replace InlineMessage with InlineMessage from deriv-com/ui (#16573) * chore: replace existing inline message component with deriv-com/ui components * chore: remove InlineMessage from base component * chore: update onfido header * chore: update MT5 badge according to design * chore: make small fixes * fix: updated copywriting * chore: update classname and cleanup css * chore: update inline message for personal details mt5 * chore: fix inline message for onfido and remove unused styles * chore: hide banner after a few seconds for success message * chore: update fix overlay on onfido * translations: 📚 sync translations with crowdin (#16825) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * fix: mt5 enter password button size (#16813) * fix: zero spread scrolling issue (#16814) * Jim/webrel 3159/add account button enabled before tnc is checked to master (#16826) * fix: disable button if tnc is not checked * chore: lift state to parent component * ci: fix test cases * chore: fix types * chore: fix button alignment inside of jurisdiction modal (#16820) * [WALL] Lubega / WEBREL-3156 / Fix console errors (#16812) * fix: console errors * fix: sonarcloud * fix: sonarcloud * fix: test case * fix: updated keys * fix: compare accounts keys * [WEBREL] Jim/WEBREL-3164/ terms and conditions issue (#16832) * [WEBREL] Jim/WEBREL-3159/add account button enabled before tnc is checked (#16815) * fix: disable button if tnc is not checked * chore: lift state to parent component * ci: fix test cases * translations: 📚 sync translations with crowdin (#16825) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * fix: mt5 enter password button size (#16813) * fix: zero spread scrolling issue (#16814) * [WALL] Lubega / WEBREL-3156 / Fix console errors (#16812) * fix: console errors * fix: sonarcloud * fix: sonarcloud * fix: test case * fix: updated keys * fix: compare accounts keys * chore: move state to parent for create password modal --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <fe-access@regentmarkets.com> Co-authored-by: lubega-deriv <142860499+lubega-deriv@users.noreply.github.com> --------- Co-authored-by: Hasan Mobarak <126637868+hasan-deriv@users.noreply.github.com> Co-authored-by: shontzu-deriv <shon.tzu@regentmarkets.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: Aum Bhatt <125039206+aum-deriv@users.noreply.github.com> Co-authored-by: rupato-deriv <97010868+rupato-deriv@users.noreply.github.com> Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <fe-access@regentmarkets.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: lubega-deriv <142860499+lubega-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
it fix the hotfix for trade test cases
Screenshots:
Please provide some screenshots of the change.