fix: test cases #16860
fix: test cases #16860
Conversation
mayuran-deriv
commented
Sep 16, 2024
•
mayuran-deriv
commented
mayuran-deriv
requested review from
sandeep-deriv and
vinu-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mayuran-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-mayuran-deriv-mayuran-utils-test-case.binary.sx/ |
mayuran-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
mayuran-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
|
|
⏳ Generating Lighthouse report... |
| @@ -20,7 +20,7 @@ export const addDynamicBlockToDOM = ( | |||
| shadow_block.appendChild(field_block); | |||
| block.appendChild(shadow_block); | |||
|
|
|||
| const amount_block = strategy_dom.querySelector('value[name="AMOUNT"]'); | |||
| const amount_block = strategy_dom?.querySelector('value[name="AMOUNT"]'); | |||
There was a problem hiding this comment.
@mayuran-deriv is it necessary to use optional chaining here? strategy_dom is a required argument. If this one is not passed, the next lines (from lines 24 to 29) will not be covered.
| jest.mock('@deriv/translations', () => ({ | ||
| localize: jest.fn((message, values) => { | ||
| let result = message; | ||
| if (values) { | ||
| Object.keys(values).forEach(key => { | ||
| result = result.replace(`{{${key}}}`, values[key]); | ||
| }); | ||
| } | ||
| return result; | ||
| }), | ||
| })); |
There was a problem hiding this comment.
@mayuran-deriv do we need to mock @deriv/translations? There is a global mock for this in here <root>/__mocks__/translation.mock.js. Doesn't it work from there?
