Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carol/ P2P: Add modal to explain why ads are not visible #4532

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

carolsachdeva
Copy link
Contributor

@carolsachdeva carolsachdeva commented Dec 29, 2021

Changes:

Please include a summary of the change and which issue is fixed below:

  • Add modal to explain why ads are not visible

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Dec 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/CewHE2ZT5jAEKTzDpF8XkNNZFDpq
✅ Preview: https://deriv-app-git-fork-carol-binary-ads-not-visible.binary.sx

@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.5% 2.5% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2021

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/4532](https://github.com/binary-com/deriv-app/pull/4532)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-carol-binary-ads-not-visible.binary.sx?qa_server=frontend.binaryws.com&app_id=23810
    - **Original**: https://deriv-app-git-fork-carol-binary-ads-not-visible.binary.sx
- **App ID**: `23810`

matin-deriv
matin-deriv previously approved these changes Dec 29, 2021
nijil-deriv
nijil-deriv previously approved these changes Jan 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants