Cashier errorcomponent testcase #4879
Conversation
…lorchange-settingsmodal
…lorchange-settingsmodal
…lorchange-settingsmodal
…-errorcomponent-testcase
ashraf-deriv
requested review from
bahar-sadeghzadeh and
nijil-deriv
as code owners
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/deriv/deriv-app/45hJoLZLf9pKwFaUcWVPtgjL4X4C |
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
…-errorcomponent-testcase
ashraf-deriv
dismissed stale reviews from nijil-deriv and likhith-deriv
via
25788bc
ashraf-deriv
requested review from
matin-deriv,
mehrzad-fs and
balakrishna-deriv
as code owners
|
Merge with current master please 🙏 |
| redirect_url={redirect_to} | ||
| redirect_label={redirect_label || <Localize i18n_default_text='Refresh' />} | ||
| redirect_urls={[redirect_to]} | ||
| redirect_labels={[redirect_label || <Localize key={0} i18n_default_text='Refresh' />]} |
There was a problem hiding this comment.
Why do we need key={0}?
There was a problem hiding this comment.
It is throwing error without the key for the element.
Codecov Report
@@ Coverage Diff @@
## master #4879 +/- ##
=======================================
Coverage 13.32% 13.32%
=======================================
Files 1284 1284
Lines 29092 29093 +1
Branches 4911 4911
=======================================
+ Hits 3876 3878 +2
Misses 24978 24978
+ Partials 238 237 -1
Continue to review full report at Codecov.
|
…-errorcomponent-testcase
…-errorcomponent-testcase
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Kudos, SonarCloud Quality Gate passed!
|
* test commit1 * platform settings font color change for select theme text in dark mode * reverted test changes * error component test case initial commit * feat: add error component test * feat: additional error components * more test coverage * rveret un wanted codes * conflicts * change test labels * error component test coverage * test case for error component and an update in routes.spec.js * remove commented code blocks * Add more coverage to the test case * revert changes done for test case run * remove commented code * fix - prop data type update for redirect_urls and redirect_labels * delete unwanted folder * code cleaning Co-authored-by: Ashraf Ali <ashrafali@Ashrafs-MacBook-Pro.local> Co-authored-by: ashrafali-v <ashrafalifrk@gmail.com> Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com>
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change