Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

likhith/payment method selection resets on tab change #4999

Merged

Conversation

likhith-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Added a store slice to track payment method changes preventing a reset during tab change

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the P2P label Mar 9, 2022
@vercel
Copy link

vercel bot commented Mar 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/B4pyeUwy8xUKH8caRNvU6nUqCaUT
✅ Preview: https://deriv-app-git-fork-likhith-deriv-fixpayment-method-selection.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/4999](https://github.com/binary-com/deriv-app/pull/4999)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-fixpayment-method-selection.binary.sx?qa_server=frontend.binaryws.com&app_id=23843
    - **Original**: https://deriv-app-git-fork-likhith-deriv-fixpayment-method-selection.binary.sx
- **App ID**: `23843`

@likhith-deriv likhith-deriv marked this pull request as ready for review March 9, 2022 13:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #4999 (e9ea4ad) into master (a2256ad) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4999      +/-   ##
==========================================
- Coverage   13.54%   13.53%   -0.01%     
==========================================
  Files        1247     1247              
  Lines       28393    28405      +12     
  Branches     4837     4838       +1     
==========================================
  Hits         3845     3845              
- Misses      24311    24323      +12     
  Partials      237      237              
Impacted Files Coverage Δ
.../components/buy-sell/filter-modal/filter-modal.jsx 0.00% <0.00%> (ø)
packages/p2p/src/stores/buy-sell-store.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2256ad...e9ea4ad. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@farrah-deriv farrah-deriv merged commit fffb2f8 into binary-com:master Apr 27, 2022
sandeep-deriv pushed a commit to sandeep-deriv/deriv-app that referenced this pull request Apr 29, 2022
* Added additional state slice to manage selected PM

* Trigger Build

* Trigger Build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants