Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vinu/Change in style of add new link inside payment method tab in p2p #5009

Merged
merged 12 commits into from
Apr 28, 2022

Conversation

vinu-deriv
Copy link
Contributor

@vinu-deriv vinu-deriv commented Mar 11, 2022

Changes:

Please include a summary of the change and which issue is fixed below:

  • Add New hyperlink in P2P Profile tab under Payments Method will have an underlined effect and hand cursor on hover.

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the P2P label Mar 11, 2022
@vercel
Copy link

vercel bot commented Mar 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/EQioiSmJNFHQqSqwpviqX261QLKW
✅ Preview: https://deriv-app-git-fork-vinu-deriv-bug-58366-p2p-add-new-link.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5009](https://github.com/binary-com/deriv-app/pull/5009)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-vinu-deriv-bug-58366-p2p-add-new-link.binary.sx?qa_server=frontend.binaryws.com&app_id=31371
    - **Original**: https://deriv-app-git-fork-vinu-deriv-bug-58366-p2p-add-new-link.binary.sx
- **App ID**: `31371`

@vinu-deriv vinu-deriv marked this pull request as ready for review March 11, 2022 12:08
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@288afc2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5009   +/-   ##
=========================================
  Coverage          ?   12.14%           
=========================================
  Files             ?     1247           
  Lines             ?    28383           
  Branches          ?     4831           
=========================================
  Hits              ?     3446           
  Misses            ?    24707           
  Partials          ?      230           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288afc2...a6581c1. Read the comment docs.

@vercel
Copy link

vercel bot commented Apr 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 28, 2022 at 8:12AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants