Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notify messsage color block #5155

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Fix notify messsage color block #5155

merged 4 commits into from
Apr 27, 2022

Conversation

rupato-deriv
Copy link
Contributor

No description provided.

@boring-cyborg boring-cyborg bot added the Bot label Apr 4, 2022
@vercel
Copy link

vercel bot commented Apr 4, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/EZ8yoNwfuQRjs9QjjzGMHHq2gJX9
✅ Preview: https://deriv-app-git-fork-rupato-deriv-fix-notify-messsage-color-block.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/5155](https://github.com/binary-com/deriv-app/pull/5155)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-fix-notify-messsage-color-block.binary.sx?qa_server=frontend.binaryws.com&app_id=31524
    - **Original**: https://deriv-app-git-fork-rupato-deriv-fix-notify-messsage-color-block.binary.sx
- **App ID**: `31524`

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022 •
edited
Loading

Codecov Report

Merging #5155 (df03e43) into master (77861e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5155   +/-   ##
=======================================
  Coverage   13.32%   13.32%           
=======================================
  Files        1284     1284           
  Lines       29093    29093           
  Branches     4911     4911           
=======================================
  Hits         3876     3876           
  Misses      24979    24979           
  Partials      238      238

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77861e5...df03e43. Read the comment docs.

sandeep-deriv
sandeep-deriv previously approved these changes Apr 4, 2022
View reviewed changes
@vercel
Copy link

vercel bot commented Apr 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 27, 2022 at 6:13AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.9% 3.9% Duplication

@farrah-deriv farrah-deriv merged commit 26f3d7a into binary-com:master Apr 27, 2022
sandeep-deriv pushed a commit to sandeep-deriv/deriv-app that referenced this pull request Apr 29, 2022
@rupato-deriv @farrah-deriv @sandeep-deriv
Fix notify messsage color block (binary-com#5155)
00b609c 
* fix for notify message block

* fix for notification colors

* minor fix for the text color change on welcome back user

Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sara-fs sara-fs sara-fs left review comments

@sandeep-deriv sandeep-deriv sandeep-deriv left review comments

@mehrzad-fs mehrzad-fs Awaiting requested review from mehrzad-fs

Assignees
No one assigned
Labels
Bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rupato-deriv @codecov-commenter @sara-fs @sandeep-deriv @farrah-deriv