Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matin/Chore: Change no open position message #5159

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

matin-deriv
Copy link
Contributor

@matin-deriv matin-deriv commented Apr 5, 2022

Changes:

Please include a summary of the change and which issue is fixed below:

  • Change no open position message

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Apr 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/AvU2W3qQX2xpH42P9ir2CiNowUeC
✅ Preview: https://deriv-app-git-fork-matin-binary-matin-openmsg.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5159](https://github.com/binary-com/deriv-app/pull/5159)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-matin-binary-matin-openmsg.binary.sx?qa_server=frontend.binaryws.com&app_id=24084
    - **Original**: https://deriv-app-git-fork-matin-binary-matin-openmsg.binary.sx
- **App ID**: `24084`

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #5159 (19b22ec) into master (77861e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5159   +/-   ##
=======================================
  Coverage   13.32%   13.32%           
=======================================
  Files        1284     1284           
  Lines       29093    29093           
  Branches     4911     4911           
=======================================
  Hits         3876     3876           
  Misses      24979    24979           
  Partials      238      238           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77861e5...19b22ec. Read the comment docs.

@maryiafrantsava-deriv
Copy link
Contributor

@matin-binary you didn’t fill the check-boxes of description changes above

aswathy-deriv
aswathy-deriv previously approved these changes Apr 5, 2022
mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Apr 5, 2022
hirad-deriv
hirad-deriv previously approved these changes Apr 5, 2022
@vercel
Copy link

vercel bot commented Apr 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 27, 2022 at 6:08AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@farrah-deriv farrah-deriv merged commit 69921d4 into binary-com:master Apr 27, 2022
sandeep-deriv pushed a commit to sandeep-deriv/deriv-app that referenced this pull request Apr 29, 2022
* Chore: Change no open position message

* Chore: Add paddings

Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants