Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adrienne/Fixed floating-point notations on buy/sell ads input amount #5168

Conversation

adrienne-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Fixed an issue where floating-point scientific notations are able to be entered in the buy/sell input amount, this includes characters such as e, E, -, + as pictured below:

Screenshot 2022-04-07 at 4 08 25 PM

  • Created validation to check for floating-point representations exclusive of scientific notations and negative numbers

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Apr 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/EnL8Y41BH6HUmx9BhtqC3emaweR4
✅ Preview: https://deriv-app-git-fork-adrienne-deriv-task-60652-floating-po-c852dd.binary.sx

@adrienne-deriv adrienne-deriv changed the title Fixed buy/sell ads input amount Fixed floating-point notations on buy/sell ads input amount Apr 8, 2022
@adrienne-deriv adrienne-deriv changed the title Fixed floating-point notations on buy/sell ads input amount Adrienne/Fixed floating-point notations on buy/sell ads input amount Apr 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5168](https://github.com/binary-com/deriv-app/pull/5168)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-task-60652-floating-po-c852dd.binary.sx?qa_server=frontend.binaryws.com&app_id=24186
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-task-60652-floating-po-c852dd.binary.sx
- **App ID**: `24186`

@vercel
Copy link

vercel bot commented Apr 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 28, 2022 at 8:05AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants