Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaryiaF/fix: hash = undefined in URL on DMT5 and DerivX #5175

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

maryia-matskevich-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Fix hash = undefined in URL on DMT5 and DerivX

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Apr 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/2PAxHghxafLmUS8sPymHNDF2tTMG
✅ Preview: https://deriv-app-git-fork-maryiafrantsava-binary-60401.binary.sx

Copy link
Contributor

@maryia-deriv-archive maryia-deriv-archive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run npm run test:eslint , build has failed unfortunately

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/5175](https://github.com/binary-com/deriv-app/pull/5175)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryiafrantsava-binary-60401.binary.sx?qa_server=frontend.binaryws.com&app_id=23826
    - **Original**: https://deriv-app-git-fork-maryiafrantsava-binary-60401.binary.sx
- **App ID**: `23826`

Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryia-matskevich-deriv
Copy link
Contributor Author

maryia-matskevich-deriv commented Apr 11, 2022

@balakrishna-binary @matin-binary @ali-hosseini-fs The issue has appeared in Codecov as 'No token specified or token is empty'. What’s wrong maybe with codecov?

@ali-hosseini-deriv
Copy link
Member

@balakrishna-binary @matin-binary @ali-hosseini-fs The issue has appeared in Codecov as 'No token specified or token is empty'. What’s wrong maybe with codecov?

I just re-ran the workflow and it passed, sometimes this happens and we just need to re-run the workflow from scratch

@maryiafrantsava-deriv
Copy link
Contributor

@balakrishna-binary @matin-binary @ali-hosseini-fs The issue has appeared in Codecov as 'No token specified or token is empty'. What’s wrong maybe with codecov?

I just re-ran the workflow and it passed, sometimes this happens and we just need to re-run the workflow from scratch

I see, thank you @ali-hosseini-fs

@vercel
Copy link

vercel bot commented Apr 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 18, 2022 at 5:57AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #5175 (59e7b24) into master (daf3591) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5175      +/-   ##
==========================================
- Coverage   13.33%   13.33%   -0.01%     
==========================================
  Files        1282     1282              
  Lines       29017    29019       +2     
  Branches     4893     4894       +1     
==========================================
  Hits         3870     3870              
- Misses      24909    24911       +2     
  Partials      238      238              
Impacted Files Coverage Δ
packages/cfd/src/Containers/cfd-dashboard.tsx 0.00% <0.00%> (ø)
packages/components/src/components/tabs/tabs.jsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf3591...59e7b24. Read the comment docs.

@matin-deriv matin-deriv merged commit 303b616 into binary-com:master Apr 20, 2022
sandeep-deriv pushed a commit to sandeep-deriv/deriv-app that referenced this pull request Apr 29, 2022
)

* MaryiaF/fix: hash = undefined in URL on DMT5 and DerivX

* MaryiaF/chore: remove commented code

* MaryiaF/chore: object key access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants