-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MaryiaF/fix: hash = undefined in URL on DMT5 and DerivX #5175
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/deriv/deriv-app/2PAxHghxafLmUS8sPymHNDF2tTMG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please run npm run test:eslint
, build has failed unfortunately
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@balakrishna-binary @matin-binary @ali-hosseini-fs The issue has appeared in Codecov as 'No token specified or token is empty'. What’s wrong maybe with codecov? |
I just re-ran the workflow and it passed, sometimes this happens and we just need to re-run the workflow from scratch |
I see, thank you @ali-hosseini-fs |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #5175 +/- ##
==========================================
- Coverage 13.33% 13.33% -0.01%
==========================================
Files 1282 1282
Lines 29017 29019 +2
Branches 4893 4894 +1
==========================================
Hits 3870 3870
- Misses 24909 24911 +2
Partials 238 238
Continue to review full report at Codecov.
|
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change