Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Binary-com/vercel-preview-url-action version #5285

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

matin-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Apr 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 20, 2022 at 10:00AM (UTC)

@codecov-commenter
Copy link

Codecov Report

Merging #5285 (d1af2fe) into master (303b616) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5285   +/-   ##
=======================================
  Coverage   13.33%   13.33%           
=======================================
  Files        1282     1282           
  Lines       29019    29019           
  Branches     4894     4894           
=======================================
  Hits         3870     3870           
  Misses      24911    24911           
  Partials      238      238           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303b616...d1af2fe. Read the comment docs.

@matin-deriv matin-deriv changed the title Empty-Commit Bump Binary-com/vercel-preview-url-action version Apr 20, 2022
@matin-deriv matin-deriv marked this pull request as ready for review April 20, 2022 09:54
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

@matin-deriv matin-deriv merged commit fbdbd08 into binary-com:master Apr 20, 2022
sandeep-deriv pushed a commit to sandeep-deriv/deriv-app that referenced this pull request Apr 29, 2022
* Empty-Commit

* Chore: bump vercel-preview_url_action version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants