Sara / fixed issue with nested list #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #5288 +/- ##
=======================================
Coverage 13.33% 13.33%
=======================================
Files 1282 1282
Lines 29020 29020
Branches 4895 4895
=======================================
Hits 3870 3870
Misses 24912 24912
Partials 238 238 Continue to review full report at Codecov.
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
mehrzad-fs
approved these changes
Apr 24, 2022
| if (!myList || !myList.length) { | ||
| return null; | ||
| } | ||
| finalList = []; |
There was a problem hiding this comment.
Suggested change
| finalList = []; | |
| var finalList = []; |
|
Kudos, SonarCloud Quality Gate passed!
|
sandeep-deriv
pushed a commit
to sandeep-deriv/deriv-app
that referenced
this pull request
Apr 29, 2022
* fixed issue with nested list * Removed global variable * Removed console log * Applied changes to average method Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change