carol/ Search box hotfix #5749
Merged
carol/ Search box hotfix #5749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 14, 2022 16:31
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
matin-deriv
reviewed
Jun 17, 2022
Comment on lines
17
to
21
| if (!search) { | ||
| onClear(); | ||
| } else { | ||
| submitForm(); | ||
| } |
There was a problem hiding this comment.
I suggest using ternary operators to simplify/shorter the code.
Codecov Report
@@ Coverage Diff @@
## master #5749 +/- ##
==========================================
- Coverage 20.90% 20.90% -0.01%
==========================================
Files 1287 1287
Lines 29261 29263 +2
Branches 4930 4930
==========================================
Hits 6117 6117
- Misses 22805 22807 +2
Partials 339 339
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
aswathy-deriv
approved these changes
Jun 20, 2022
vinu-deriv
pushed a commit
to vinu-deriv/deriv-app
that referenced
this pull request
Jun 21, 2022
* search hotfix * search hotfix * fix: intermittent issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change