Adrienne / Changed styling for Inactive chip and long text is wrapped when overflown #5974
Conversation
adrienne-deriv
requested review from
carolsachdeva and
nijil-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Codecov Report
@@ Coverage Diff @@
## master #5974 +/- ##
==========================================
+ Coverage 22.03% 22.05% +0.01%
==========================================
Files 1349 1349
Lines 30136 30136
Branches 4988 4987 -1
==========================================
+ Hits 6640 6646 +6
+ Misses 23135 23129 -6
Partials 361 361
Continue to review full report at Codecov.
|
| border-radius: 1.6rem; | ||
| padding: 0.2rem 1.6rem; | ||
| width: 8.8rem; | ||
| } |
There was a problem hiding this comment.
is it fine to have the mixins here or should we add this to the mixins.scss?
There was a problem hiding this comment.
In my opinion, not really since this mixin is only included here for reducing code duplication and is only specific for ad status styling, since both the active and inactive ad status share a lot of the same css properties. If maybe however in the future we have mixins that is reusable like making calculations etc, we could include it in our own mixins.scss file for P2P
|
Kudos, SonarCloud Quality Gate passed!
|
| border-radius: 1.6rem; | ||
| background-color: $background-color; | ||
| } | ||
| align-items: center; |
There was a problem hiding this comment.
Added align-items: center and justify-content: center to center the text for active and inactive ad status
Before
After
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change