Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adrienne / Refactored blocked user overlay css and advertiser page css #6097

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Adrienne / Refactored blocked user overlay css and advertiser page css #6097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9eaca8
Refactored blocked user overlay css and advertiser page css
adrienne-deriv Aug 4, 2022
305dd76
Fixed merge conflicts
adrienne-deriv Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/p2p/src/components/advertiser-page/advertiser-page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,10 @@
padding: 2.4rem;
border: 1px solid var(--general-hover);
border-radius: 0.8rem;

@include mobile {
border-radius: unset;
Copy link
Contributor Author

@adrienne-deriv adrienne-deriv Aug 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In design, advertiser page stats for responsive has no border radius, fixing this in case in the future QA comes back with this issue

Before

Screenshot 2022-08-04 at 11 07 32 AM

After

Screenshot 2022-08-04 at 11 08 55 AM

}
}
}

Expand Down
6 changes: 2 additions & 4 deletions .../p2p/src/components/advertiser-page/block-user/block-user-overlay/block-user-overlay.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,12 @@
opacity: 0.9;
top: 0;
left: 0;
width: 94rem;
z-index: 1;
width: 100%;
z-index: 9999;

@include mobile {
border: none;
border-radius: unset;
width: 100%;
height: 100%;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parent &__wrapper already includes width: 100% and height: 100%, refactoring this since its basically duplicated code

flex-flow: column;
}

Expand Down