Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sara / Fixed issue with qs validation #6249

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

sara-fs
Copy link
Contributor

@sara-fs sara-fs commented Aug 21, 2022

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Bot label Aug 21, 2022
@vercel
Copy link

vercel bot commented Aug 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 9:56AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6249](https://github.com/binary-com/deriv-app/pull/6249)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sara-fs-martingale-validation-issue.binary.sx?qa_server=frontend.binaryws.com&app_id=24020
    - **Original**: https://deriv-app-git-fork-sara-fs-martingale-validation-issue.binary.sx
- **App ID**: `24020`

@codecov-commenter
Copy link

Codecov Report

Merging #6249 (adaf94a) into master (e381065) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6249   +/-   ##
=======================================
  Coverage   21.76%   21.76%           
=======================================
  Files        1386     1386           
  Lines       31487    31487           
  Branches     5362     5362           
=======================================
  Hits         6854     6854           
  Misses      24240    24240           
  Partials      393      393           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
3.7% 3.7% Duplication

@prince-deriv prince-deriv merged commit 16a93bf into binary-com:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants