Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hamid/74301/handle-timeout-in-account-transfer-form #6270

Merged

Conversation

hamid-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Aug 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 2:15PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6270](https://github.com/binary-com/deriv-app/pull/6270)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamid-deriv-hamid-74301failed-at-timeout.binary.sx?qa_server=frontend.binaryws.com&app_id=31359
    - **Original**: https://deriv-app-git-fork-hamid-deriv-hamid-74301failed-at-timeout.binary.sx
- **App ID**: `31359`

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #6270 (1161bec) into master (16a93bf) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6270   +/-   ##
=======================================
  Coverage   21.76%   21.76%           
=======================================
  Files        1386     1386           
  Lines       31487    31486    -1     
  Branches     5362     5362           
=======================================
  Hits         6854     6854           
+ Misses      24240    24239    -1     
  Partials      393      393           
Impacted Files Coverage Δ
...ts/crypto-fiat-converter/crypto-fiat-converter.tsx 79.41% <ø> (+2.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nijil-deriv nijil-deriv marked this pull request as ready for review August 26, 2022 07:19
@hamid-deriv hamid-deriv changed the title Handle timeout in account transfer form hamid/74301/handle-timeout-in-account-transfer-form Aug 28, 2022
@farrah-deriv farrah-deriv merged commit f120ff9 into binary-com:master Aug 29, 2022
@hamid-deriv hamid-deriv deleted the hamid/74301/failed-at-timeout branch April 4, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants